From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Wed, 4 Feb 2015 09:59:16 +0100 Subject: [U-Boot] [PATCH 3/5] arm: Allow lr to be saved by board code In-Reply-To: <1423023534-4318-3-git-send-email-sjg@chromium.org> References: <1423023534-4318-1-git-send-email-sjg@chromium.org> <1423023534-4318-3-git-send-email-sjg@chromium.org> Message-ID: <20150204095916.5c5cbb31@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On Tue, 3 Feb 2015 21:18:52 -0700, Simon Glass wrote: > The link register value can be required on some boards (e.g. FEL mode on > sunxi) so stash it to r4 before jumping to save_boot_params(). I'd rather not make this there; I would like save_boot_params to start with as unmodified a core state as possible, because r4 might actually, now or in the future, contain important data. I'd even go as far as saying that save_boot_params should be branched into rather than called, and should branch back to a fixed label right after reset, so that even lr is preserved. For SoCs which do not need to save any boot parameters, a weak version of save_boot_params would just do the branching back. (this should help merging all start.S instances into a singe one, which I still want to achieve one day) > Signed-off-by: Simon Glass > --- Amicalement, -- Albert.