From: Parmeshwr Prasad <parmeshwr_prasad@dell.com> To: Borislav Petkov <bp@alien8.de>, Matt Fleming <matt@console-pimps.org>, Randy Dunlap <rdunlap@infradead.org>, Jon Masters <jonathan@jonmasters.org>, Laszlo Ersek <lersek@redhat.com>, Dave Young <dyoung@redhat.com>, linux-efi <linux-efi@vger.kernel.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Matt Fleming <matt.fleming@intel.com>, Ricardo Neri <ricardo.neri-calderon@linux.intel.com>, lkml <linux-kernel@vger.kernel.org>, parmeshwr_prasad@dell.com Subject: Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Date: Wed, 4 Feb 2015 07:18:10 -0500 [thread overview] Message-ID: <20150204121805.GA18368@linuxteamdev.amer.dell.com> (raw) In-Reply-To: <54CBC815.5060502@infradead.org> Some messages from efifb also should be suppressed. It will be better if we can move them under efi=debug kernel parameter. Please review the following patch. >From 7fbac896ab87f1b37646ac2f49bb8216ec330642 Mon Sep 17 00:00:00 2001 From: Parmeshwr Prasad <parmeshwr_prasad@dell.com> Date: Wed, 4 Feb 2015 06:50:32 -0500 Subject: [PATCH] efi, x86: Add a debug option to the efi= cmdline Signed-off-by: Parmeshwr Prasad <parmeshwr_prasad@dell.com> --- drivers/video/fbdev/efifb.c | 49 +++++++++++++++++++++++++-------------------- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index 4bfff34..505bc56 100644 --- a/drivers/video/fbdev/efifb.c +++ b/drivers/video/fbdev/efifb.c @@ -145,7 +145,8 @@ static int efifb_probe(struct platform_device *dev) printk(KERN_DEBUG "efifb: invalid framebuffer address\n"); return -ENODEV; } - printk(KERN_INFO "efifb: probing for efifb\n"); + if (efi_enabled(EFI_DBG)) + printk(KERN_INFO "efifb: probing for efifb\n"); /* just assume they're all unset if any are */ if (!screen_info.blue_size) { @@ -224,20 +225,22 @@ static int efifb_probe(struct platform_device *dev) err = -EIO; goto err_release_fb; } - - printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, " - "using %dk, total %dk\n", - efifb_fix.smem_start, info->screen_base, - size_remap/1024, size_total/1024); - printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n", - efifb_defined.xres, efifb_defined.yres, - efifb_defined.bits_per_pixel, efifb_fix.line_length, - screen_info.pages); + if (efi_enabled(EFI_DBG)){ + printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, " + "using %dk, total %dk\n", + efifb_fix.smem_start, info->screen_base, + size_remap/1024, size_total/1024); + printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n", + efifb_defined.xres, efifb_defined.yres, + efifb_defined.bits_per_pixel, efifb_fix.line_length, + screen_info.pages); + } efifb_defined.xres_virtual = efifb_defined.xres; efifb_defined.yres_virtual = efifb_fix.smem_len / efifb_fix.line_length; - printk(KERN_INFO "efifb: scrolling: redraw\n"); + if (efi_enabled(EFI_DBG)) + printk(KERN_INFO "efifb: scrolling: redraw\n"); efifb_defined.yres_virtual = efifb_defined.yres; /* some dummy values for timing to make fbset happy */ @@ -255,17 +258,19 @@ static int efifb_probe(struct platform_device *dev) efifb_defined.transp.offset = screen_info.rsvd_pos; efifb_defined.transp.length = screen_info.rsvd_size; - printk(KERN_INFO "efifb: %s: " - "size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", - "Truecolor", - screen_info.rsvd_size, - screen_info.red_size, - screen_info.green_size, - screen_info.blue_size, - screen_info.rsvd_pos, - screen_info.red_pos, - screen_info.green_pos, - screen_info.blue_pos); + if (efi_enabled(EFI_DBG)){ + printk(KERN_INFO "efifb: %s: " + "size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", + "Truecolor", + screen_info.rsvd_size, + screen_info.red_size, + screen_info.green_size, + screen_info.blue_size, + screen_info.rsvd_pos, + screen_info.red_pos, + screen_info.green_pos, + screen_info.blue_pos); + } efifb_fix.ypanstep = 0; efifb_fix.ywrapstep = 0; -- 1.9.3 Fri, Jan 30, 2015 at 12:06:13PM -0600, Randy Dunlap wrote: > On 01/30/15 08:43, Borislav Petkov wrote: > > From: Borislav Petkov <bp@suse.de> > > Date: Mon, 26 Jan 2015 19:49:59 +0100 > > Subject: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline > > > > Please update Documentation/kernel-parameters.txt also. > > > ... and hide the memory regions dump behind it. Make it default-off. > > > > Signed-off-by: Borislav Petkov <bp@suse.de> > > Link: http://lkml.kernel.org/r/20141209095843.GA3990@pd.tnic > > --- > > arch/x86/platform/efi/efi.c | 5 ++++- > > include/linux/efi.h | 1 + > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > > index dbc8627a5cdf..e859d56ce9f8 100644 > > --- a/arch/x86/platform/efi/efi.c > > +++ b/arch/x86/platform/efi/efi.c > > @@ -491,7 +491,8 @@ void __init efi_init(void) > > if (efi_memmap_init()) > > return; > > > > - print_efi_memmap(); > > + if (efi_enabled(EFI_DBG)) > > + print_efi_memmap(); > > } > > > > void __init efi_late_init(void) > > @@ -939,6 +940,8 @@ static int __init arch_parse_efi_cmdline(char *str) > > { > > if (parse_option_str(str, "old_map")) > > set_bit(EFI_OLD_MEMMAP, &efi.flags); > > + if (parse_option_str(str, "debug")) > > + set_bit(EFI_DBG, &efi.flags); > > > > return 0; > > } > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > index 0238d612750e..14cec75d7e74 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *); > > #define EFI_64BIT 5 /* Is the firmware 64-bit? */ > > #define EFI_PARAVIRT 6 /* Access is via a paravirt interface */ > > #define EFI_ARCH_1 7 /* First arch-specific bit */ > > +#define EFI_DBG 8 /* Print additional debug info at runtime */ > > > > #ifdef CONFIG_EFI > > /* > > > > > -- > ~Randy > -- > To unsubscribe from this list: send the line "unsubscribe linux-efi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Parmeshwr Prasad <parmeshwr_prasad-8PEkshWhKlo@public.gmane.org> To: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>, Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>, Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Jon Masters <jonathan-Zp4isUonpHBD60Wz+7aTrA@public.gmane.org>, Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, linux-efi <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Ricardo Neri <ricardo.neri-calderon-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, parmeshwr_prasad-8PEkshWhKlo@public.gmane.org Subject: Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Date: Wed, 4 Feb 2015 07:18:10 -0500 [thread overview] Message-ID: <20150204121805.GA18368@linuxteamdev.amer.dell.com> (raw) In-Reply-To: <54CBC815.5060502-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Some messages from efifb also should be suppressed. It will be better if we can move them under efi=debug kernel parameter. Please review the following patch. >From 7fbac896ab87f1b37646ac2f49bb8216ec330642 Mon Sep 17 00:00:00 2001 From: Parmeshwr Prasad <parmeshwr_prasad-8PEkshWhKlo@public.gmane.org> Date: Wed, 4 Feb 2015 06:50:32 -0500 Subject: [PATCH] efi, x86: Add a debug option to the efi= cmdline Signed-off-by: Parmeshwr Prasad <parmeshwr_prasad-8PEkshWhKlo@public.gmane.org> --- drivers/video/fbdev/efifb.c | 49 +++++++++++++++++++++++++-------------------- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index 4bfff34..505bc56 100644 --- a/drivers/video/fbdev/efifb.c +++ b/drivers/video/fbdev/efifb.c @@ -145,7 +145,8 @@ static int efifb_probe(struct platform_device *dev) printk(KERN_DEBUG "efifb: invalid framebuffer address\n"); return -ENODEV; } - printk(KERN_INFO "efifb: probing for efifb\n"); + if (efi_enabled(EFI_DBG)) + printk(KERN_INFO "efifb: probing for efifb\n"); /* just assume they're all unset if any are */ if (!screen_info.blue_size) { @@ -224,20 +225,22 @@ static int efifb_probe(struct platform_device *dev) err = -EIO; goto err_release_fb; } - - printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, " - "using %dk, total %dk\n", - efifb_fix.smem_start, info->screen_base, - size_remap/1024, size_total/1024); - printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n", - efifb_defined.xres, efifb_defined.yres, - efifb_defined.bits_per_pixel, efifb_fix.line_length, - screen_info.pages); + if (efi_enabled(EFI_DBG)){ + printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, " + "using %dk, total %dk\n", + efifb_fix.smem_start, info->screen_base, + size_remap/1024, size_total/1024); + printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n", + efifb_defined.xres, efifb_defined.yres, + efifb_defined.bits_per_pixel, efifb_fix.line_length, + screen_info.pages); + } efifb_defined.xres_virtual = efifb_defined.xres; efifb_defined.yres_virtual = efifb_fix.smem_len / efifb_fix.line_length; - printk(KERN_INFO "efifb: scrolling: redraw\n"); + if (efi_enabled(EFI_DBG)) + printk(KERN_INFO "efifb: scrolling: redraw\n"); efifb_defined.yres_virtual = efifb_defined.yres; /* some dummy values for timing to make fbset happy */ @@ -255,17 +258,19 @@ static int efifb_probe(struct platform_device *dev) efifb_defined.transp.offset = screen_info.rsvd_pos; efifb_defined.transp.length = screen_info.rsvd_size; - printk(KERN_INFO "efifb: %s: " - "size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", - "Truecolor", - screen_info.rsvd_size, - screen_info.red_size, - screen_info.green_size, - screen_info.blue_size, - screen_info.rsvd_pos, - screen_info.red_pos, - screen_info.green_pos, - screen_info.blue_pos); + if (efi_enabled(EFI_DBG)){ + printk(KERN_INFO "efifb: %s: " + "size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", + "Truecolor", + screen_info.rsvd_size, + screen_info.red_size, + screen_info.green_size, + screen_info.blue_size, + screen_info.rsvd_pos, + screen_info.red_pos, + screen_info.green_pos, + screen_info.blue_pos); + } efifb_fix.ypanstep = 0; efifb_fix.ywrapstep = 0; -- 1.9.3 Fri, Jan 30, 2015 at 12:06:13PM -0600, Randy Dunlap wrote: > On 01/30/15 08:43, Borislav Petkov wrote: > > From: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org> > > Date: Mon, 26 Jan 2015 19:49:59 +0100 > > Subject: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline > > > > Please update Documentation/kernel-parameters.txt also. > > > ... and hide the memory regions dump behind it. Make it default-off. > > > > Signed-off-by: Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org> > > Link: http://lkml.kernel.org/r/20141209095843.GA3990-fF5Pk5pvG8Y@public.gmane.org > > --- > > arch/x86/platform/efi/efi.c | 5 ++++- > > include/linux/efi.h | 1 + > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > > index dbc8627a5cdf..e859d56ce9f8 100644 > > --- a/arch/x86/platform/efi/efi.c > > +++ b/arch/x86/platform/efi/efi.c > > @@ -491,7 +491,8 @@ void __init efi_init(void) > > if (efi_memmap_init()) > > return; > > > > - print_efi_memmap(); > > + if (efi_enabled(EFI_DBG)) > > + print_efi_memmap(); > > } > > > > void __init efi_late_init(void) > > @@ -939,6 +940,8 @@ static int __init arch_parse_efi_cmdline(char *str) > > { > > if (parse_option_str(str, "old_map")) > > set_bit(EFI_OLD_MEMMAP, &efi.flags); > > + if (parse_option_str(str, "debug")) > > + set_bit(EFI_DBG, &efi.flags); > > > > return 0; > > } > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > index 0238d612750e..14cec75d7e74 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *); > > #define EFI_64BIT 5 /* Is the firmware 64-bit? */ > > #define EFI_PARAVIRT 6 /* Access is via a paravirt interface */ > > #define EFI_ARCH_1 7 /* First arch-specific bit */ > > +#define EFI_DBG 8 /* Print additional debug info at runtime */ > > > > #ifdef CONFIG_EFI > > /* > > > > > -- > ~Randy > -- > To unsubscribe from this list: send the line "unsubscribe linux-efi" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-02-04 12:28 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-09 9:58 Shorten efi regions output Borislav Petkov 2014-12-09 9:58 ` Borislav Petkov 2014-12-09 12:42 ` Ard Biesheuvel 2014-12-09 12:42 ` Ard Biesheuvel 2014-12-09 12:48 ` Borislav Petkov 2014-12-09 12:48 ` Borislav Petkov 2014-12-09 15:35 ` Laszlo Ersek 2014-12-09 15:35 ` Laszlo Ersek 2014-12-09 16:45 ` Borislav Petkov 2014-12-09 16:45 ` Borislav Petkov 2014-12-10 2:17 ` Dave Young 2014-12-10 2:17 ` Dave Young 2014-12-10 10:46 ` Borislav Petkov 2014-12-10 10:46 ` Borislav Petkov 2015-01-05 14:03 ` Matt Fleming 2015-01-05 14:03 ` Matt Fleming 2015-01-05 15:00 ` Laszlo Ersek 2015-01-21 5:48 ` Jon Masters 2015-01-21 10:06 ` Borislav Petkov 2015-01-21 10:06 ` Borislav Petkov 2015-01-26 10:49 ` Matt Fleming 2015-01-30 16:43 ` [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Borislav Petkov 2015-01-30 16:43 ` Borislav Petkov 2015-01-30 16:58 ` Laszlo Ersek 2015-01-30 16:58 ` Laszlo Ersek 2015-01-30 18:06 ` Randy Dunlap 2015-01-30 18:06 ` Randy Dunlap 2015-01-30 21:17 ` Borislav Petkov 2015-01-30 21:17 ` Borislav Petkov 2015-02-04 12:18 ` Parmeshwr Prasad [this message] 2015-02-04 12:18 ` Parmeshwr Prasad 2015-02-05 3:18 ` Dave Young 2015-02-05 3:18 ` Dave Young 2015-02-05 8:11 ` Borislav Petkov 2015-02-05 8:11 ` Borislav Petkov 2015-02-05 8:41 ` Dave Young 2015-02-05 8:41 ` Dave Young 2015-02-05 10:44 ` [PATCH v2] " Borislav Petkov 2015-02-05 10:44 ` Borislav Petkov 2015-02-05 12:45 ` Parmeshwr Prasad 2015-02-05 12:45 ` Parmeshwr Prasad 2015-02-05 14:28 ` Borislav Petkov 2015-02-06 6:00 ` Parmeshwr Prasad 2015-02-06 6:00 ` Parmeshwr Prasad 2015-02-06 10:49 ` Borislav Petkov 2015-02-06 10:49 ` Borislav Petkov 2015-02-24 22:33 ` Matt Fleming 2015-02-24 22:33 ` Matt Fleming 2015-04-02 12:27 ` [tip:core/efi] x86/efi: " tip-bot for Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150204121805.GA18368@linuxteamdev.amer.dell.com \ --to=parmeshwr_prasad@dell.com \ --cc=ard.biesheuvel@linaro.org \ --cc=bp@alien8.de \ --cc=dyoung@redhat.com \ --cc=jonathan@jonmasters.org \ --cc=lersek@redhat.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=matt.fleming@intel.com \ --cc=matt@console-pimps.org \ --cc=rdunlap@infradead.org \ --cc=ricardo.neri-calderon@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.