From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755599AbbBDOKZ (ORCPT ); Wed, 4 Feb 2015 09:10:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:46075 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbbBDOKY (ORCPT ); Wed, 4 Feb 2015 09:10:24 -0500 Date: Wed, 4 Feb 2015 15:10:20 +0100 From: Joerg Roedel To: Baoquan He Cc: Joerg Roedel , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Konrad Rzeszutek Wilk , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high Message-ID: <20150204141020.GB10078@suse.de> References: <1420555874-11506-1-git-send-email-joro@8bytes.org> <1420555874-11506-4-git-send-email-joro@8bytes.org> <20150123084453.GL2461@dhcp-16-105.nay.redhat.com> <20150126120756.GF30345@8bytes.org> <20150201084103.GB1573@dhcp-17-102.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150201084103.GB1573@dhcp-17-102.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baoquan, On Sun, Feb 01, 2015 at 04:41:03PM +0800, Baoquan He wrote: > Before I said 256M may not be a good value, that's because in your patch > cover you said this number comes from experiments on the affected > systems, and 128M was still not enough, then you set it to 256M. This > may be a little rush. I think the step size to increase should be 32M, > after all previously people only take 64M and 8M, enlarge it on a step > size of 128M only one time, it can't be seen as patient and careful. > If it failed on 224M but succeed on 256M, then 256M may be not enough. > I would like to say 32M is better, then we can make a good evaluate. That makes sense. I also asked the customer to test intermediate values, we already know that it works with 256MB but also that 128MB are not enough. I will report back when I have the results of the intermediate values in 32MB steps. Thanks, Joerg