From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753803AbbBEIMO (ORCPT ); Thu, 5 Feb 2015 03:12:14 -0500 Received: from mail.skyhub.de ([78.46.96.112]:60826 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbbBEIMM (ORCPT ); Thu, 5 Feb 2015 03:12:12 -0500 Date: Thu, 5 Feb 2015 09:11:43 +0100 From: Borislav Petkov To: Dave Young Cc: Matt Fleming , Jon Masters , Laszlo Ersek , linux-efi , Ard Biesheuvel , Matt Fleming , Ricardo Neri , lkml Subject: Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Message-ID: <20150205081143.GA23980@pd.tnic> References: <20141209095843.GA3990@pd.tnic> <20141210021741.GA3280@darkstar.nay.redhat.com> <20141210104627.GA17053@pd.tnic> <20150105140332.GB3163@console-pimps.org> <54AAA723.1070605@redhat.com> <54BF3DCA.4070708@jonmasters.org> <20150121100633.GC12173@pd.tnic> <20150126104936.GB3320@codeblueprint.co.uk> <20150130164309.GG1451@pd.tnic> <20150205031846.GA1903@darkstar.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150205031846.GA1903@darkstar.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 05, 2015 at 11:18:46AM +0800, Dave Young wrote: > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > index 0238d612750e..14cec75d7e74 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *); > > #define EFI_64BIT 5 /* Is the firmware 64-bit? */ > > #define EFI_PARAVIRT 6 /* Access is via a paravirt interface */ > > #define EFI_ARCH_1 7 /* First arch-specific bit */ > > +#define EFI_DBG 8 /* Print additional debug info at runtime */ > > Boris, a nickpick about alignment of the second column.. This is due to how diffs show tabs. See EFI_PARAVIRT above, it appears misaligned too. If you switch to list mode in vim, for example, it'll show you how many tabs are being used: #define EFI_PARAVIRT^I^I6^I/* Access is via a paravirt interface */$ #define EFI_ARCH_1^I^I7^I/* First arch-specific bit */$ #define EFI_DBG^I^I^I8^I/* Print additional debug info at runtime */$ and EFI_DBG has an additional tab. However, the vertical alignment is correct. You can apply the patch and see for yourself :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Date: Thu, 5 Feb 2015 09:11:43 +0100 Message-ID: <20150205081143.GA23980@pd.tnic> References: <20141209095843.GA3990@pd.tnic> <20141210021741.GA3280@darkstar.nay.redhat.com> <20141210104627.GA17053@pd.tnic> <20150105140332.GB3163@console-pimps.org> <54AAA723.1070605@redhat.com> <54BF3DCA.4070708@jonmasters.org> <20150121100633.GC12173@pd.tnic> <20150126104936.GB3320@codeblueprint.co.uk> <20150130164309.GG1451@pd.tnic> <20150205031846.GA1903@darkstar.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20150205031846.GA1903-4/PLUo9XfK/1wF9wiOj0lkEOCMrvLtNR@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: Matt Fleming , Jon Masters , Laszlo Ersek , linux-efi , Ard Biesheuvel , Matt Fleming , Ricardo Neri , lkml List-Id: linux-efi@vger.kernel.org On Thu, Feb 05, 2015 at 11:18:46AM +0800, Dave Young wrote: > > diff --git a/include/linux/efi.h b/include/linux/efi.h > > index 0238d612750e..14cec75d7e74 100644 > > --- a/include/linux/efi.h > > +++ b/include/linux/efi.h > > @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *); > > #define EFI_64BIT 5 /* Is the firmware 64-bit? */ > > #define EFI_PARAVIRT 6 /* Access is via a paravirt interface */ > > #define EFI_ARCH_1 7 /* First arch-specific bit */ > > +#define EFI_DBG 8 /* Print additional debug info at runtime */ > > Boris, a nickpick about alignment of the second column.. This is due to how diffs show tabs. See EFI_PARAVIRT above, it appears misaligned too. If you switch to list mode in vim, for example, it'll show you how many tabs are being used: #define EFI_PARAVIRT^I^I6^I/* Access is via a paravirt interface */$ #define EFI_ARCH_1^I^I7^I/* First arch-specific bit */$ #define EFI_DBG^I^I^I8^I/* Print additional debug info at runtime */$ and EFI_DBG has an additional tab. However, the vertical alignment is correct. You can apply the patch and see for yourself :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --