From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?q?Roh=C3=A1r?= Subject: Re: [PATCH 0/6] Fixes for ALPS trackstick Date: Thu, 5 Feb 2015 12:41:36 +0100 Message-ID: <201502051241.36857@pali> References: <1421276154-8689-1-git-send-email-dmitry.torokhov@gmail.com> <201501181047.06541@pali> <20150202054931.GB20333@dtor-ws> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2779394.OXmHhG5vVE"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f42.google.com ([74.125.82.42]:51704 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbbBELlk (ORCPT ); Thu, 5 Feb 2015 06:41:40 -0500 Received: by mail-wg0-f42.google.com with SMTP id x13so7115988wgg.1 for ; Thu, 05 Feb 2015 03:41:39 -0800 (PST) In-Reply-To: <20150202054931.GB20333@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Hans de Goede , linux-input@vger.kernel.org, Vadim Klishko --nextPart2779394.OXmHhG5vVE Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote: > On Sun, Jan 18, 2015 at 10:47:06AM +0100, Pali Roh=C3=A1r wrote: > > On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote: > > > On Sat, Jan 17, 2015 at 11:01:56AM +0100, Pali Roh=C3=A1r wrote: > > > > On Thursday 15 January 2015 22:02:16 Dmitry Torokhov=20 wrote: > > > > > On Thu, Jan 15, 2015 at 09:28:41PM +0100, Pali Roh=C3=A1r=20 wrote: > > > > > > On Thursday 15 January 2015 20:38:18 Dmitry Torokhov > >=20 > > wrote: > > > > > > > On Thu, Jan 15, 2015 at 08:19:59PM +0100, Pali > > > > > > > Roh=C3=A1r > >=20 > > wrote: > > > > > > > > On Thursday 15 January 2015 19:18:20 Dmitry > > > > > > > > Torokhov > > > >=20 > > > > wrote: > > > > > > > > > On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali > > > > > > > > > Roh=C3=A1r > > > >=20 > > > > wrote: > > > > > > > > > > On Wednesday 14 January 2015 23:55:48 Dmitry > > > > > > > > > > Torokhov > > > > > >=20 > > > > > > wrote: > > > > > > > > > > > Hi Pali, > > > > > > > > > > >=20 > > > > > > > > > > > This series try to address the issue you > > > > > > > > > > > brought regarding trackstick > > > > > > > > > > > initialization on Dell Latitudes in a > > > > > > > > > > > different way than the patches you > > > > > > > > > > > proposed. Basically in this series we > > > > > > > > > > > move resetting and all detection in > > > > > > > > > > > alps_detect() and make sure we keep the > > > > > > > > > > > state so alps_init() can reuse it and not > > > > > > > > > > > perform the detection all over again. > > > > > > > > > > > Doing this allows us to set up device > > > > > > > > > > > characteristics (name, version, etc) > > > > > > > > > > > properly from the get go while still > > > > > > > > > > > performing reset only once. > > > > > > > > > > >=20 > > > > > > > > > > > This is untested as I do not have any ALPS > > > > > > > > > > > devices anymore so I'd appreciate you > > > > > > > > > > > giving it a spin. > > > > > > > > > > >=20 > > > > > > > > > > > Thanks! > > > > > > > > > >=20 > > > > > > > > > > Hi Dmitry, > > > > > > > > > >=20 > > > > > > > > > > on top of which branch/repository should I > > > > > > > > > > apply your patches? > > > > > > > > >=20 > > > > > > > > > Should be applicable to my 'next' branch > > > > > > > > > (which I just upreved to 3.19-rc4). > > > > > > > > >=20 > > > > > > > > > Thanks. > > > > > > > >=20 > > > > > > > > Not working at top of next (0c3e994). > > > > > > > >=20 > > > > > > > > Applying: Input: ALPS - renumber protocol > > > > > > > > numbers Applying: Input: ALPS - make Rushmore a > > > > > > > > separate protocol error: patch failed: > > > > > > > > drivers/input/mouse/alps.c:1275 error: > > > > > > > > drivers/input/mouse/alps.c: patch does not apply > > > > > > > > Patch failed at 0002 Input: ALPS - make Rushmore > > > > > > > > a separate protocol > > > > > > >=20 > > > > > > > Hmm.. I created a new alps branch (based on > > > > > > > 3.19-rc4), can you try it? > > > > > > >=20 > > > > > > > Thanks. > > > > > >=20 > > > > > > Compiled from your new alps branch (with "if > > > > > > (!priv)" fix) and modprobing psmouse.ko caused > > > > > > laptop freeze :-( Even sysrq not responded. So > > > > > > something is not working... > > > > >=20 > > > > > Hmm, is it on text console or in X? Any chance you > > > > > could go through pathes - there are only 8 of them > > > > > including 2 of yours that should be unmodified. > > > > >=20 > > > > > Thanks. > > > >=20 > > > > Hi, now I tested patch by patch and kernel crash is > > > > caused only by last patch 6/6 and only after I touch > > > > touchpad or trackstick. > > > >=20 > > > > In text console it prints lot of panic messages and > > > > because it prints lot of messages I cannot read (or > > > > record) more then last. > > > >=20 > > > > In last call trace I see that > > > > alps_register_bare_ps2_mouse() was called and it > > > > generated page_fault. > > >=20 > > > That happens because while you added priv->psmouse pointer > > > it looks like you forgot to initialize it and I missed > > > that too... > >=20 > > Right your patch 6/6 does not initialize priv->psmouse. I > > looked into my original patch and it initialize it, so > > there was some copy-paste error. > >=20 > > Look at other emails... can you fix problems and send new > > version of your patches for testing? >=20 > I think I did. Can you please take another look at my alps > branch? >=20 > Thanks! You did not fixed commit message which add dev3 device. It should=20 be "do not mix trackstick ...". =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart2779394.OXmHhG5vVE Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlTTVvAACgkQi/DJPQPkQ1KerACgozSep43ltIXBhDAi39/DqQfo xSQAoK/5uxF+NoxQq97FJYNIyEaYeRS1 =3MNB -----END PGP SIGNATURE----- --nextPart2779394.OXmHhG5vVE--