From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Li, Aubrey" <aubrey.li@linux.intel.com>,
"Brown, Len" <len.brown@intel.com>,
Alan Cox <alan@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [Update] Re: [PATCH v3]PM/Sleep: Timer quiesce in freeze state
Date: Fri, 6 Feb 2015 17:14:54 +0100 [thread overview]
Message-ID: <20150206161454.GQ21418@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <2439333.L8nfGI3YZp@vostro.rjw.lan>
On Fri, Feb 06, 2015 at 02:20:13AM +0100, Rafael J. Wysocki wrote:
> void freeze_wake(void)
> {
> + unsigned long flags;
> +
> + spin_lock_irqsave(&suspend_freeze_lock, flags);
> + if (suspend_freeze_state > FREEZE_STATE_NONE) {
> + suspend_freeze_state = FREEZE_STATE_WAKE;
> + wake_up(&suspend_freeze_wait_head);
> + }
> + spin_unlock_irqrestore(&suspend_freeze_lock, flags);
> }
> +static void enter_freeze_proper(struct cpuidle_driver *drv,
> + struct cpuidle_device *dev, int index)
> +{
> + tick_freeze();
> + drv->states[index].enter_freeze(dev, drv, index);
> + /*
> + * timekeeping_resume() that will be called by tick_unfreeze() for the
> + * last CPU executing it calls functions containing RCU read-side
> + * critical sections, so tell RCU about that.
> + */
> + RCU_NONIDLE(tick_unfreeze());
> +}
So I'm a wee bit confused; if we use an enter_freeze() state that keeps
interrupts disabled; who is going to call the freeze_wake() thing?
next prev parent reply other threads:[~2015-02-06 16:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 3:01 [PATCH v3]PM/Sleep: Timer quiesce in freeze state Li, Aubrey
2015-01-14 0:24 ` Li, Aubrey
2015-01-19 15:24 ` Rafael J. Wysocki
2015-01-22 10:15 ` Thomas Gleixner
2015-01-26 8:44 ` Li, Aubrey
2015-01-26 9:40 ` Thomas Gleixner
2015-01-26 14:21 ` Rafael J. Wysocki
2015-01-26 14:15 ` Thomas Gleixner
2015-01-26 14:45 ` Rafael J. Wysocki
2015-01-27 7:12 ` Li, Aubrey
2015-01-26 14:41 ` Rafael J. Wysocki
2015-01-26 14:24 ` Thomas Gleixner
2015-01-26 14:50 ` Rafael J. Wysocki
2015-01-26 14:34 ` Thomas Gleixner
2015-01-26 15:04 ` Rafael J. Wysocki
2015-01-27 8:03 ` Li, Aubrey
2015-01-27 15:10 ` Rafael J. Wysocki
2015-01-28 0:17 ` Li, Aubrey
2015-01-29 22:20 ` Rafael J. Wysocki
2015-02-06 1:20 ` [Update] " Rafael J. Wysocki
2015-02-06 16:14 ` Peter Zijlstra [this message]
2015-02-06 18:29 ` Peter Zijlstra
2015-02-06 22:36 ` Rafael J. Wysocki
2015-02-09 9:49 ` Peter Zijlstra
2015-02-09 14:50 ` Rafael J. Wysocki
2015-02-09 2:54 ` [Update 2x] " Rafael J. Wysocki
2015-02-09 15:20 ` Peter Zijlstra
2015-02-09 15:44 ` Peter Zijlstra
2015-02-09 23:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206161454.GQ21418@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alan@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.