From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754101AbbBFQjK (ORCPT ); Fri, 6 Feb 2015 11:39:10 -0500 Received: from mail.skyhub.de ([78.46.96.112]:59946 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855AbbBFQjI (ORCPT ); Fri, 6 Feb 2015 11:39:08 -0500 Date: Fri, 6 Feb 2015 17:38:37 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tony.luck@intel.com, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH V2] x86, mce, amd: Enable interrupts by default if HW capable Message-ID: <20150206163837.GI3220@pd.tnic> References: <1422896561-7695-1-git-send-email-aravind.gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1422896561-7695-1-git-send-email-aravind.gopalakrishnan@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 02, 2015 at 11:02:41AM -0600, Aravind Gopalakrishnan wrote: > We setup APIC vectors for threshold errors if interrupt_capable. > However, we don't set interrupt_enable by default. > Re-working threshold_restart_bank() here so that the first time we > set up lvt_offset, we also set IntType to APIC. > > User is still allowed to disable interrupts through sysfs. > > While at it, check if status is valid before we proceed to log > error using mce_log. This is because, in multi-node platforms, > only NBC has valid status info. So, the decoding of status values > on the non-NBC leads to noise on kernel logs like so- > > [ 440.509744] EDAC DEBUG: amd64_inject_write_store: section=0x80000000 > word_bits=0x10020001 > [ 466.570925] [Hardware Error]: Corrected error, no action required. > [ 466.570935] [Hardware Error]: CPU:25 (15:2:0) MC4_STATUS[-|CE|-|-|- > [ 466.570936] [Hardware Error]: Corrected error, no action required. > [ 466.570959] [Hardware Error]: CPU:26 (15:2:0) MC4_STATUS[-|CE|-|-|- > <...> > [ 466.571293] WARNING: CPU: 25 PID: 0 at drivers/edac/amd64_edac.c:2147 > decode_bus_error+0x1ba/0x2a0() > [ 466.571301] WARNING: CPU: 26 PID: 0 at drivers/edac/amd64_edac.c:2147 > decode_bus_error+0x1ba/0x2a0() > [ 466.571303] Something is rotten in the state of Denmark. > > Suggested-by: Borislav Petkov > Signed-off-by: Aravind Gopalakrishnan Queued for 3.21, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --