From: David Miller <davem@redhat.com>
To: ycheng@google.com
Cc: edumazet@google.com, ncardwell@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] tcp: don't include Fast Open option in SYN-ACK on pure SYN-data
Date: Mon, 09 Feb 2015 14:27:32 -0800 (PST) [thread overview]
Message-ID: <20150209.142732.243638519161010259.davem@redhat.com> (raw)
In-Reply-To: <1423514123-6825-1-git-send-email-ycheng@google.com>
From: Yuchung Cheng <ycheng@google.com>
Date: Mon, 9 Feb 2015 12:35:23 -0800
> If a server has enabled Fast Open and it receives a pure SYN-data
> packet (without a Fast Open option), it won't accept the data but it
> incorrectly returns a SYN-ACK with a Fast Open cookie and also
> increments the SNMP stat LINUX_MIB_TCPFASTOPENPASSIVEFAIL.
>
> This patch makes the server include a Fast Open cookie in SYN-ACK
> only if the SYN has some Fast Open option (i.e., when client
> requests or presents a cookie).
>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Acked-by: Neal Cardwell <ncardwell@google.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
next prev parent reply other threads:[~2015-02-09 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 20:35 [PATCH net] tcp: don't include Fast Open option in SYN-ACK on pure SYN-data Yuchung Cheng
2015-02-09 22:27 ` David Miller [this message]
[not found] <1423183446-15280-1-git-send-email-ycheng@google.com>
2015-02-06 0:58 ` Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209.142732.243638519161010259.davem@redhat.com \
--to=davem@redhat.com \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.