Re: [PATCH] drm/i915: Use symbolic irqreturn for ->hpd_pulse

From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Dave Airlie <airlied@redhat.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Use symbolic irqreturn for ->hpd_pulse
Date: Mon, 9 Feb 2015 17:48:04 +0100	[thread overview]
Message-ID: <20150209164804.GB24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150206184912.GK9152@intel.com>

On Fri, Feb 06, 2015 at 08:49:12PM +0200, Ville Syrjälä wrote:
> On Fri, Jan 23, 2015 at 06:00:31AM +0100, Daniel Vetter wrote:
> > Self-explanatory code is better code.
> 
> This causes the VDD off -> HPD -> VDD on -> VDD off -> HPD ... cycle to
> make another appearance on my BSW. Looks like you forgot to convert one return
> in intel_dp_hpd_pulse():
> 
> @@ -4499,7 +4499,7 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
>                  */
>                 DRM_DEBUG_KMS("ignoring long hpd on eDP port %c\n",
>                               port_name(intel_dig_port->port));
> -               return false;
> +               return IRQ_HANDLED;
>         }
>  
>         DRM_DEBUG_KMS("got hpd irq on port %c - %s\n",

Oh dear that's rather bad. Can you please supply a full patch so that Jani
can take it up for dinf? Free Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
fwiw (which isn't much).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx