From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761550AbbBIXH1 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Feb 2015 18:07:27 -0500
Received: from mail-wi0-f179.google.com ([209.85.212.179]:35791 "EHLO
	mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1761472AbbBIXHZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Feb 2015 18:07:25 -0500
Date: Tue, 10 Feb 2015 00:07:17 +0100
From: AdrianRemonda <adrianremonda@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
        "moderated list:STAGING - LUSTRE..." <HPDD-discuss@ml01.01.org>,
        Andreas Dilger <andreas.dilger@intel.com>,
        open list <linux-kernel@vger.kernel.org>,
        Oleg Drokin <oleg.drokin@intel.com>,
        Anton Saraev <antonysaraev@gmail.com>
Subject: Re: Question regarding sparse warning in staging/lustre
Message-ID: <20150209230717.GA9173@debian.home>
References: <1423430844-28740-1-git-send-email-adrianremonda@gmail.com>
 <20150208234023.GA8572@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150208234023.GA8572@kroah.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 09, 2015 at 07:40:23AM +0800, Greg Kroah-Hartman wrote:
> On Sun, Feb 08, 2015 at 10:27:23PM +0100, Adrian Remonda wrote:
> > Hello,
> > 
> > I'm cleaning the drivers/staging/lustre driver.
> > I have got the next warning from sparse:
> > 
> > drivers/staging/lustre/lnet/selftest//conctl.c:918:30: warning: incorrect type in argument 1 (different address spaces)
> > drivers/staging/lustre/lnet/selftest//conctl.c:918:30:    expected void [noderef] <asn:1>*to
> > drivers/staging/lustre/lnet/selftest//conctl.c:918:30:    got char *ioc_pbuf2
> > 
> > If I add the __user macro as next:
> > 
> > --- a/drivers/staging/lustre/lnet/selftest/conctl.c
> > +++ b/drivers/staging/lustre/lnet/selftest/conctl.c
> > @@ -46,7 +46,7 @@
> >  #include "console.h"
> >  
> >  static int
> > -lst_session_new_ioctl(lstio_session_new_args_t *args)
> > +lst_session_new_ioctl(lstio_session_new_args_t __user *args)
> >  {
> >  	char      *name;
> >  	int	rc;
> >  	
> > The warning turns to:
> > 
> > drivers/staging/lustre/lnet/selftest//conctl.c:825:13: warning: dereference of noderef expression
> > 
> > Now the question:
> > Is this right or it is just a false warning from sparse? 
> > Should the __user macro should be also inside the structure fields?
> 
> The user/kernel fields in lustre are a total mess, I wouldn't work on
> them if you don't have to as they need an overhaul in some areas.
> 
> So I'd recommend just staying away :)
> 
> good luck!
> 
> greg k-h

Ok. I had already done some modifications anyway. I sent you the patch
of the few I did

Regards,
Adrian