From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755443AbbBJM0X (ORCPT ); Tue, 10 Feb 2015 07:26:23 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:54492 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751032AbbBJM0W (ORCPT ); Tue, 10 Feb 2015 07:26:22 -0500 Date: Tue, 10 Feb 2015 07:27:01 -0500 From: Steven Rostedt To: Alexei Starovoitov Cc: Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Linux API , Network Development , LKML , Linus Torvalds Subject: Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C Message-ID: <20150210072701.547a5385@grimm.local.home> In-Reply-To: References: <1423539961-21792-1-git-send-email-ast@plumgrid.com> <1423539961-21792-5-git-send-email-ast@plumgrid.com> <20150209230836.7f913c60@grimm.local.home> <20150210001608.157a9190@grimm.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Feb 2015 21:47:42 -0800 Alexei Starovoitov wrote: > On Mon, Feb 9, 2015 at 9:45 PM, Alexei Starovoitov wrote: > > I thought we already stated that. > > Here is the quote from perf_event.h: > > * # The RAW record below is opaque data wrt the ABI > > * # > > * # That is, the ABI doesn't make any promises wrt to > > * # the stability of its content, it may vary depending > > * # on event, hardware, kernel version and phase of > > * # the moon. > > * # > > * # In other words, PERF_SAMPLE_RAW contents are not an ABI. > > > > and this example is reading PERF_SAMPLE_RAW events and > > uses locally defined structs to print them for simplicity. > > to underline my point once more: > addition of bpf doesn't change at all what PERF_SAMPLE_RAW already > delivers to user space. > so no new ABIs anywhere. Again, it we give an example of how to hard code the data, definitely expect this to show up in user space. Users are going to look at this code to learn how to use eBPF. I really want it to do it the correct way instead of the 'easy' way. Because whatever way we have it here, will be the way we will see it out in the wild. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH v3 linux-trace 4/8] samples: bpf: simple tracing example in C Date: Tue, 10 Feb 2015 07:27:01 -0500 Message-ID: <20150210072701.547a5385@grimm.local.home> References: <1423539961-21792-1-git-send-email-ast@plumgrid.com> <1423539961-21792-5-git-send-email-ast@plumgrid.com> <20150209230836.7f913c60@grimm.local.home> <20150210001608.157a9190@grimm.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Linux API , Network Development , LKML , Linus Torvalds To: Alexei Starovoitov Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, 9 Feb 2015 21:47:42 -0800 Alexei Starovoitov wrote: > On Mon, Feb 9, 2015 at 9:45 PM, Alexei Starovoitov wrote: > > I thought we already stated that. > > Here is the quote from perf_event.h: > > * # The RAW record below is opaque data wrt the ABI > > * # > > * # That is, the ABI doesn't make any promises wrt to > > * # the stability of its content, it may vary depending > > * # on event, hardware, kernel version and phase of > > * # the moon. > > * # > > * # In other words, PERF_SAMPLE_RAW contents are not an ABI. > > > > and this example is reading PERF_SAMPLE_RAW events and > > uses locally defined structs to print them for simplicity. > > to underline my point once more: > addition of bpf doesn't change at all what PERF_SAMPLE_RAW already > delivers to user space. > so no new ABIs anywhere. Again, it we give an example of how to hard code the data, definitely expect this to show up in user space. Users are going to look at this code to learn how to use eBPF. I really want it to do it the correct way instead of the 'easy' way. Because whatever way we have it here, will be the way we will see it out in the wild. -- Steve