From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754374AbbBKWFg (ORCPT ); Wed, 11 Feb 2015 17:05:36 -0500 Received: from mail-qg0-f42.google.com ([209.85.192.42]:39684 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbbBKWFe (ORCPT ); Wed, 11 Feb 2015 17:05:34 -0500 Date: Wed, 11 Feb 2015 17:05:30 -0500 From: Tejun Heo To: Konstantin Khlebnikov Cc: Greg Thelen , Konstantin Khlebnikov , Johannes Weiner , Michal Hocko , Cgroups , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Jan Kara , Dave Chinner , Jens Axboe , Christoph Hellwig , Li Zefan , Hugh Dickins Subject: Re: [RFC] Making memcg track ownership per address_space or anon_vma Message-ID: <20150211220530.GA12728@htj.duckdns.org> References: <20150206141746.GB10580@htj.dyndns.org> <20150207143839.GA9926@htj.dyndns.org> <20150211021906.GA21356@htj.duckdns.org> <20150211203359.GF21356@htj.duckdns.org> <20150211214650.GA11920@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 12, 2015 at 01:57:04AM +0400, Konstantin Khlebnikov wrote: > On Thu, Feb 12, 2015 at 12:46 AM, Tejun Heo wrote: > > Hello, > > > > On Thu, Feb 12, 2015 at 12:22:34AM +0300, Konstantin Khlebnikov wrote: > >> > Yeah, available memory to the matching memcg and the number of dirty > >> > pages in it. It's gonna work the same way as the global case just > >> > scoped to the cgroup. > >> > >> That might be a problem: all dirty pages accounted to cgroup must be > >> reachable for its own personal writeback or balanace-drity-pages will be > >> unable to satisfy memcg dirty memory thresholds. I've done accounting > > > > Yeah, it would. Why wouldn't it? > > How do you plan to do per-memcg/blkcg writeback for balance-dirty-pages? > Or you're thinking only about separating writeback flow into blkio cgroups > without actual inode filtering? I mean delaying inode writeback and keeping > dirty pages as long as possible if their cgroups are far from threshold. What? The code was already in the previous patchset. I'm just gonna rip out the code to handle inode being dirtied on multiple wb's. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f53.google.com (mail-yh0-f53.google.com [209.85.213.53]) by kanga.kvack.org (Postfix) with ESMTP id C6E596B006E for ; Wed, 11 Feb 2015 17:05:34 -0500 (EST) Received: by mail-yh0-f53.google.com with SMTP id i57so2502190yha.12 for ; Wed, 11 Feb 2015 14:05:34 -0800 (PST) Received: from mail-qa0-x232.google.com (mail-qa0-x232.google.com. [2607:f8b0:400d:c00::232]) by mx.google.com with ESMTPS id t5si2543923qar.69.2015.02.11.14.05.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 14:05:34 -0800 (PST) Received: by mail-qa0-f50.google.com with SMTP id f12so4957930qad.9 for ; Wed, 11 Feb 2015 14:05:33 -0800 (PST) Date: Wed, 11 Feb 2015 17:05:30 -0500 From: Tejun Heo Subject: Re: [RFC] Making memcg track ownership per address_space or anon_vma Message-ID: <20150211220530.GA12728@htj.duckdns.org> References: <20150206141746.GB10580@htj.dyndns.org> <20150207143839.GA9926@htj.dyndns.org> <20150211021906.GA21356@htj.duckdns.org> <20150211203359.GF21356@htj.duckdns.org> <20150211214650.GA11920@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Konstantin Khlebnikov Cc: Greg Thelen , Konstantin Khlebnikov , Johannes Weiner , Michal Hocko , Cgroups , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Jan Kara , Dave Chinner , Jens Axboe , Christoph Hellwig , Li Zefan , Hugh Dickins On Thu, Feb 12, 2015 at 01:57:04AM +0400, Konstantin Khlebnikov wrote: > On Thu, Feb 12, 2015 at 12:46 AM, Tejun Heo wrote: > > Hello, > > > > On Thu, Feb 12, 2015 at 12:22:34AM +0300, Konstantin Khlebnikov wrote: > >> > Yeah, available memory to the matching memcg and the number of dirty > >> > pages in it. It's gonna work the same way as the global case just > >> > scoped to the cgroup. > >> > >> That might be a problem: all dirty pages accounted to cgroup must be > >> reachable for its own personal writeback or balanace-drity-pages will be > >> unable to satisfy memcg dirty memory thresholds. I've done accounting > > > > Yeah, it would. Why wouldn't it? > > How do you plan to do per-memcg/blkcg writeback for balance-dirty-pages? > Or you're thinking only about separating writeback flow into blkio cgroups > without actual inode filtering? I mean delaying inode writeback and keeping > dirty pages as long as possible if their cgroups are far from threshold. What? The code was already in the previous patchset. I'm just gonna rip out the code to handle inode being dirtied on multiple wb's. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [RFC] Making memcg track ownership per address_space or anon_vma Date: Wed, 11 Feb 2015 17:05:30 -0500 Message-ID: <20150211220530.GA12728@htj.duckdns.org> References: <20150206141746.GB10580@htj.dyndns.org> <20150207143839.GA9926@htj.dyndns.org> <20150211021906.GA21356@htj.duckdns.org> <20150211203359.GF21356@htj.duckdns.org> <20150211214650.GA11920@htj.duckdns.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ZWH46ZitBdElJ6G4UUnD2Gn58kpL/c6HGfqSv21Ysyk=; b=ec3CaWFO0JSpIENE3hglBRWaTGYTuIkZklrD76hCn45IFCUfGLB8nyPyQaT9DNa6BN LTjEssddaySZ67nwdTgn5fsc1rC4Zf0hpQ9TBmiWWnSQe8QMK5Pla2F35P+zcdX2n02n lDxO5yOBGkItUU8y/GjKXxx+gnVbNgpJDG1kvZcl5Hk934gwHkn992yTXnJG4S2SwMmd syAIzMnJalpze9jEJGFN/jTUgV7gzSSyDfZqxir8QGsWdz77beRoyAgPmO0izsiZHN+k RDv64eleeJ7146QD1xkXuaBWrCcFl9xMBKyjXrSzh1XZCfOt3s/n+/+rfHPHp5Z6KwZa yFMA== Content-Disposition: inline In-Reply-To: Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Konstantin Khlebnikov Cc: Greg Thelen , Konstantin Khlebnikov , Johannes Weiner , Michal Hocko , Cgroups , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jan Kara , Dave Chinner , Jens Axboe , Christoph Hellwig , Li Zefan , Hugh Dickins On Thu, Feb 12, 2015 at 01:57:04AM +0400, Konstantin Khlebnikov wrote: > On Thu, Feb 12, 2015 at 12:46 AM, Tejun Heo wrote: > > Hello, > > > > On Thu, Feb 12, 2015 at 12:22:34AM +0300, Konstantin Khlebnikov wrote: > >> > Yeah, available memory to the matching memcg and the number of dirty > >> > pages in it. It's gonna work the same way as the global case just > >> > scoped to the cgroup. > >> > >> That might be a problem: all dirty pages accounted to cgroup must be > >> reachable for its own personal writeback or balanace-drity-pages will be > >> unable to satisfy memcg dirty memory thresholds. I've done accounting > > > > Yeah, it would. Why wouldn't it? > > How do you plan to do per-memcg/blkcg writeback for balance-dirty-pages? > Or you're thinking only about separating writeback flow into blkio cgroups > without actual inode filtering? I mean delaying inode writeback and keeping > dirty pages as long as possible if their cgroups are far from threshold. What? The code was already in the previous patchset. I'm just gonna rip out the code to handle inode being dirtied on multiple wb's. -- tejun