From: Stephen Boyd <sboyd@codeaurora.org>
To: Gilad Avidov <gavidov@codeaurora.org>
Cc: sdharia@codeaurora.org, mlocke@codeaurora.org,
linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, iivanov@mm-sol.com,
galak@codeaurora.org, agross@codeaurora.org
Subject: Re: [PATCH V3 0/2] add support for pmic_arb v2 and correct framework
Date: Wed, 11 Feb 2015 16:53:15 -0800 [thread overview]
Message-ID: <20150212005315.GH11190@codeaurora.org> (raw)
In-Reply-To: <20150211110542.4e6d7218@gavidov-lnx.qualcomm.com>
On 02/11, Gilad Avidov wrote:
> On Mon, 09 Feb 2015 15:08:58 -0800
> Stephen Boyd <sboyd@codeaurora.org> wrote:
>
> > On 02/09/15 14:51, Gilad Avidov wrote:
> > > pmic_arb v2 has no support for spmi non-data commands and thus
> > > returns -EOPNOTSUPP on .cmd callback. This causes a failure in
> > > spmi_drv_probe() which sends a wakeup command to the slave before
> > > probing its driver. This patchset removes the wakeup from
> > > spmi_drv_probe() since the spmi spec stipulates that a slaves
> > > default state is active and doesn't need a wakeup.
> >
> > The spec also seems to stipulate that SPMI masters shall support all
> > SPMI command sequences.
>
> Regardless of the master's support, a wakeup call before prob is not
> required.
Yes that seems to match what the spec says.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-02-12 0:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 22:51 [PATCH V3 0/2] add support for pmic_arb v2 and correct framework Gilad Avidov
2015-02-09 22:51 ` [PATCH V3 1/2] spmi: remove wakeup command before slave probe Gilad Avidov
2015-02-18 15:39 ` Josh Cartwright
2015-02-18 19:17 ` Stephen Boyd
2015-02-19 19:23 ` Gilad Avidov
2015-02-09 22:51 ` [PATCH V3 2/2] spmi: pmic_arb: add support for hw version 2 Gilad Avidov
2015-02-18 15:34 ` Josh Cartwright
2015-02-19 17:29 ` Gilad Avidov
2015-02-09 23:08 ` [PATCH V3 0/2] add support for pmic_arb v2 and correct framework Stephen Boyd
2015-02-11 18:05 ` Gilad Avidov
2015-02-12 0:53 ` Stephen Boyd [this message]
2015-02-13 19:50 ` Gilad Avidov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212005315.GH11190@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.