From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v5 18/24] libxl: disallow memory relocation
 when vNUMA is enabled
Date: Fri, 13 Feb 2015 15:18:49 +0000
Message-ID: <20150213151849.GG13644@zion.uk.xensource.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-19-git-send-email-wei.liu2@citrix.com>
	<21726.1924.561971.591200@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <21726.1924.561971.591200@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, ian.campbell@citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, ufimtseva@gmail.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Feb 13, 2015 at 02:17:40PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v5 18/24] libxl: disallow memory relocation when vNUMA is enabled"):
> > Disallow memory relocation when vNUMA is enabled, because relocated
> > memory ends up off node. Further more, even if we dynamically expand
> > node coverage in hvmloader, low memory and high memory may reside
> > in different physical nodes, blindly relocating low memory to high
> > memory gives us a sub-optimal configuration.
> ...
> >                          "%d",
> > -                        b_info->device_model_version==LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL);
> > +                        b_info->device_model_version==LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL &&
> > +                        !b_info->num_vnuma_nodes);
> 
> I think it would be useful to add a helper function
>   libxl__vnuma_configured()
> to replace all these open-coded !b_info calls etc.
> 
> That will make things easier if the vnuma specification arrangements
> change, and it will make the code more readable too I think.
> 

Ack.

Wei.

> Thanks,
> Ian.