From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754183AbbBNQLi (ORCPT <rfc822;w@1wt.eu>);
	Sat, 14 Feb 2015 11:11:38 -0500
Received: from 8bytes.org ([81.169.241.247]:33091 "EHLO theia.8bytes.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753965AbbBNQLh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 14 Feb 2015 11:11:37 -0500
Date: Sat, 14 Feb 2015 17:11:35 +0100
From: Joerg Roedel <joro@8bytes.org>
To: Baoquan He <bhe@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 0/3 v2] Fix kdump failures with crashkernel=high
Message-ID: <20150214161135.GJ29106@8bytes.org>
References: <1420555874-11506-1-git-send-email-joro@8bytes.org>
 <20150214105834.GA7478@dhcp-17-102.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150214105834.GA7478@dhcp-17-102.nay.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Baoquan,

On Sat, Feb 14, 2015 at 06:58:34PM +0800, Baoquan He wrote:
> This patch is very helpful and necessary since several users complained
> about the failure caused by not enough low mem. And the default value
> 256M is suitable since the testing data showed it's sufficient
> now and should be save for a long time.
>  
> And it also makes sense to supress the warning from buddy allocation
> failure which will call dump_stack in x86_swiotlb_alloc_coherent. Since
> it tried buddy allocation several times before the final try of bounce
> buffer allocation.
> 
> So ack the whole patch set.
> 
> Acked-by: Baoquan He <bhe@redhat.com> 

Thanks a lot!

> Hi Joerg,
> 
> Thanks for your effort on this issue. 
> 
> Could you please also update the cover letter or patch log to tell
> how 256M comes out with the later test result? I think it is convincing
> and helpful to understand.

Sure thing, will update the patch description before I resend the
series.


Regards,

	Joerg