From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v5 04/24] libxc: add p2m_size to xc_dom_image Date: Mon, 16 Feb 2015 14:49:18 +0000 Message-ID: <20150216144918.GA20572@zion.uk.xensource.com> References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com> <1423770294-9779-5-git-send-email-wei.liu2@citrix.com> <1424098012.6968.26.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1424098012.6968.26.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Wei Liu , "JBeulich@suse.com" , Andrew Cooper , "xen-devel@lists.xen.org" , "ufimtseva@gmail.com" , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Mon, Feb 16, 2015 at 02:46:54PM +0000, Dario Faggioli wrote: > On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote: > > Add a new field p2m_size to keep track of the number of pages covert by > > > Here and in the code (comment): is it 'covert' or 'covered' (or maybe > even something else)? Should be "covered". > > In any case... > > > p2m. Change total_pages to p2m_size in functions which in fact need > > the size of p2m. > > > > This is needed because we are going to ditch the assumption that PV x86 > > has only one contiguous ram region. Originally the p2m size was always > > equal to total_pages, but we will soon change that in later patch. > > > > This patch doesn't change the behaviour of libxc. > > > > Signed-off-by: Wei Liu > > Cc: Ian Campbell > > Cc: Ian Jackson > > > ... Reviewed-by: Dario Faggioli > Thanks. Wei. > Regards, > Dario