From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v5 05/24] libxc: allocate memory with vNUMA
 information for PV guest
Date: Mon, 16 Feb 2015 17:44:05 +0000
Message-ID: <20150216174405.GJ20572@zion.uk.xensource.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-6-git-send-email-wei.liu2@citrix.com>
	<1424105889.2591.56.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1424105889.2591.56.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, "JBeulich@suse.com" <JBeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "ufimtseva@gmail.com" <ufimtseva@gmail.com>, Ian Jackson <Ian.Jackson@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, Feb 16, 2015 at 04:58:11PM +0000, Dario Faggioli wrote:
> On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:
> 
> > @@ -760,7 +760,8 @@ static int x86_shadow(xc_interface *xch, domid_t domid)
> >  int arch_setup_meminit(struct xc_dom_image *dom)
> >  {
> >      int rc;
> > -    xen_pfn_t pfn, allocsz, i, j, mfn;
> > +    xen_pfn_t pfn, allocsz, mfn, total, pfn_base;
> > +    int i, j;
> >  
> >      rc = x86_compat(dom->xch, dom->guest_domid, dom->guest_type);
> >      if ( rc )
> > @@ -811,26 +812,101 @@ int arch_setup_meminit(struct xc_dom_image *dom)
> >              if ( rc )
> >                  return rc;
> >          }
> > -        /* setup initial p2m */
> > -        dom->p2m_size = dom->total_pages;
> > +
> > +        /* Setup dummy vNUMA information if it's not provided. Note
> > +         * that this is a valid state if libxl doesn't provide any
> > +         * vNUMA information.
> > +         *
> > +         * The dummy values make libxc allocate all pages from
> > +         * arbitrary physical. This is the expected behaviour if no
> > +         * vNUMA configuration is provided to libxc.
> > +         *
> "from arbitrary phisical nodes" maybe (or something like that?)
> 

Fixed. Thanks.

Wei.

> Also, it feels like these two paragraphs can be merged into one. Not a
> bit deal, though, and the rest of the patch also looks fine.
> 
> Regards,
> Dario