From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756824AbbBQLLZ (ORCPT ); Tue, 17 Feb 2015 06:11:25 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:42249 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755156AbbBQLLX (ORCPT ); Tue, 17 Feb 2015 06:11:23 -0500 Date: Tue, 17 Feb 2015 12:11:16 +0100 From: Peter Zijlstra To: Kirill Tkhai Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Josh Poimboeuf Subject: Re: [PATCH 1/2] sched: Move __task_rq_{, un}lock() to kernel/sched/sched.h Message-ID: <20150217111116.GL5029@twins.programming.kicks-ass.net> References: <1424170011.5749.20.camel@tkhai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424170011.5749.20.camel@tkhai> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2015 at 01:46:51PM +0300, Kirill Tkhai wrote: > > Place it in sched.h, because dl_task_timer() needs it. > Also remove lockdep check, which is not fit to this > function. No, that lockdep check is valid for all current sites.