From: Jeff Layton <jeff.layton@primarydata.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"J. Bruce Fields" <bfields@fieldses.org>,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <david@fromorbit.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH 0/4] locks: flock and lease related bugfixes, and remove i_flctx counters
Date: Tue, 17 Feb 2015 16:10:53 -0500 [thread overview]
Message-ID: <20150217161053.2aa2b7d9@tlielax.poochiereds.net> (raw)
In-Reply-To: <20150217202049.GN29656@ZenIV.linux.org.uk>
On Tue, 17 Feb 2015 20:20:49 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Tue, Feb 17, 2015 at 11:55:01AM -0800, Linus Torvalds wrote:
>
> > Can we get that truncated series tested with some flock test suite? I
> > assume there is *some* filesystem tester that tests some basic flock
> > stuff, even if it clearly didn't catch the race due to the unlock in
> > the middle..
>
> LTP runltp -f syscalls does cover some of that; BTW, looks like fcntl11,
> fcntl11_64, fcntl21 and fcntl21_64 in there got broken by something already
> merged. Hadn't don bisect yet, but seeing
> * NAME
> * fcntl11.c
> *
> * DESCRIPTION
> * Testcase to check locking of regions of a file
> *
> * ALGORITHM
> * Test changing lock sections around a write lock
> and
> * NAME
> * fcntl21.c
> *
> * DESCRIPTION
> * Check locking of regions of a file
> *
> * ALGORITHM
> * Test changing lock sections around a read lock
>
> I'd say that file locking merge is most likely suspect...
Almost certainly. I'll take a look.
Thanks,
--
Jeff Layton <jeff.layton@primarydata.com>
prev parent reply other threads:[~2015-02-17 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 12:46 [PATCH 0/4] locks: flock and lease related bugfixes, and remove i_flctx counters Jeff Layton
2015-02-17 12:46 ` [PATCH 1/4] Revert "locks: keep a count of locks on the flctx lists" Jeff Layton
2015-02-17 12:46 ` [PATCH 2/4] locks: remove conditional lock release in middle of flock_lock_file Jeff Layton
2015-02-17 17:10 ` J. Bruce Fields
2015-02-17 17:56 ` Jeff Layton
2015-02-17 19:11 ` J. Bruce Fields
2015-02-17 22:21 ` J. Bruce Fields
2015-02-17 22:29 ` Jeff Layton
2015-02-17 12:46 ` [PATCH 3/4] locks: when upgrading, don't remove old flock lock until replacing with new one Jeff Layton
2015-02-17 12:46 ` [PATCH 4/4] locks: only remove leases associated with the file being closed Jeff Layton
2015-02-17 19:55 ` [PATCH 0/4] locks: flock and lease related bugfixes, and remove i_flctx counters Linus Torvalds
2015-02-17 20:20 ` Linus Torvalds
2015-02-17 20:20 ` Al Viro
2015-02-17 21:10 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217161053.2aa2b7d9@tlielax.poochiereds.net \
--to=jeff.layton@primarydata.com \
--cc=bfields@fieldses.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.