From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754725AbbBQUUz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Feb 2015 15:20:55 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:50261 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751545AbbBQUUx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Feb 2015 15:20:53 -0500
Date: Tue, 17 Feb 2015 20:20:49 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Layton <jeff.layton@primarydata.com>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Christoph Hellwig <hch@lst.de>, Dave Chinner <david@fromorbit.com>,
        Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH 0/4] locks: flock and lease related bugfixes, and remove
 i_flctx counters
Message-ID: <20150217202049.GN29656@ZenIV.linux.org.uk>
References: <1424177190-14252-1-git-send-email-jeff.layton@primarydata.com>
 <CA+55aFwdAg_St3_qJPSHfityE7772taoPKwSg1M3B0WiBWnCsA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFwdAg_St3_qJPSHfityE7772taoPKwSg1M3B0WiBWnCsA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 17, 2015 at 11:55:01AM -0800, Linus Torvalds wrote:

> Can we get that truncated series tested with some flock test suite? I
> assume there is *some* filesystem tester that tests some basic flock
> stuff, even if it clearly didn't catch the race due to the unlock in
> the middle..

LTP runltp -f syscalls does cover some of that; BTW, looks like fcntl11,
fcntl11_64, fcntl21 and fcntl21_64 in there got broken by something already
merged.  Hadn't don bisect yet, but seeing
 * NAME
 *      fcntl11.c
 *
 * DESCRIPTION
 *      Testcase to check locking of regions of a file
 *
 * ALGORITHM  
 *      Test changing lock sections around a write lock
and
 * NAME
 *      fcntl21.c
 *
 * DESCRIPTION
 *      Check locking of regions of a file
 *
 * ALGORITHM
 *      Test changing lock sections around a read lock

I'd say that file locking merge is most likely suspect...