From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbbBRKd0 (ORCPT ); Wed, 18 Feb 2015 05:33:26 -0500 Received: from down.free-electrons.com ([37.187.137.238]:38322 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751646AbbBRKdZ (ORCPT ); Wed, 18 Feb 2015 05:33:25 -0500 Date: Wed, 18 Feb 2015 11:33:22 +0100 From: Antoine Tenart To: Sebastian Hesselbarth Cc: Antoine Tenart , jszhang@marvell.com, zmxu@marvell.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/11] ARM: berlin: rework chip and system controller nodes for BG2 Message-ID: <20150218103322.GA16432@kwain> References: <1423671332-24580-1-git-send-email-antoine.tenart@free-electrons.com> <1423671332-24580-10-git-send-email-antoine.tenart@free-electrons.com> <54E4699E.4010909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54E4699E.4010909@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian! On Wed, Feb 18, 2015 at 11:29:50AM +0100, Sebastian Hesselbarth wrote: > On 11.02.2015 17:15, Antoine Tenart wrote: > [...] > >- chip: chip-control@ea0000 { > >- compatible = "marvell,berlin2-chip-ctrl"; > >- #clock-cells = <1>; > >- #reset-cells = <2>; > >+ chip: chip-controller@ea0000 { > >+ compatible = "marvell,berlin2-chip-ctrl", "syscon"; > > reg = <0xea0000 0x400>; > >+ #clock-cells = <1>; > > I noticed just now, but we should either have all of clock, reset, > pinctrl as sub-nodes or none. Currently, this has pinctrl and reset > as sub-nodes but clock hooked up to chip-controller. Of course. The clock rework is part of the other series[1] which modifies the clock driver to use regmap but also move the clock into its own sub-node. Antoine [1] https://lkml.org/lkml/2015/2/13/252 -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: antoine.tenart@free-electrons.com (Antoine Tenart) Date: Wed, 18 Feb 2015 11:33:22 +0100 Subject: [PATCH 09/11] ARM: berlin: rework chip and system controller nodes for BG2 In-Reply-To: <54E4699E.4010909@gmail.com> References: <1423671332-24580-1-git-send-email-antoine.tenart@free-electrons.com> <1423671332-24580-10-git-send-email-antoine.tenart@free-electrons.com> <54E4699E.4010909@gmail.com> Message-ID: <20150218103322.GA16432@kwain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sebastian! On Wed, Feb 18, 2015 at 11:29:50AM +0100, Sebastian Hesselbarth wrote: > On 11.02.2015 17:15, Antoine Tenart wrote: > [...] > >- chip: chip-control at ea0000 { > >- compatible = "marvell,berlin2-chip-ctrl"; > >- #clock-cells = <1>; > >- #reset-cells = <2>; > >+ chip: chip-controller at ea0000 { > >+ compatible = "marvell,berlin2-chip-ctrl", "syscon"; > > reg = <0xea0000 0x400>; > >+ #clock-cells = <1>; > > I noticed just now, but we should either have all of clock, reset, > pinctrl as sub-nodes or none. Currently, this has pinctrl and reset > as sub-nodes but clock hooked up to chip-controller. Of course. The clock rework is part of the other series[1] which modifies the clock driver to use regmap but also move the clock into its own sub-node. Antoine [1] https://lkml.org/lkml/2015/2/13/252 -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com