From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbbBTQNE (ORCPT ); Fri, 20 Feb 2015 11:13:04 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:37039 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754761AbbBTQNA (ORCPT ); Fri, 20 Feb 2015 11:13:00 -0500 Date: Fri, 20 Feb 2015 17:12:49 +0100 From: Michael Mueller To: Richard Henderson Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , frank.blaschka@de.ibm.com Subject: Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines Message-ID: <20150220171249.210a0236@bee> In-Reply-To: <54E75AA2.9070503@twiddle.net> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-11-git-send-email-mimu@linux.vnet.ibm.com> <54E75AA2.9070503@twiddle.net> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022016-0009-0000-0000-000003375B11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Feb 2015 08:02:42 -0800 Richard Henderson wrote: > > +/** > > + * s390_test_facility - test if given facility bit is set facility list > > + * of given cpu class > > + * @class: address of cpu class to test > > + * @nr: bit number to test > > + * > > + * Returns: true in case it is set > > + * false in case it is not set > > + */ > > +bool s390_test_facility(S390CPUClass *cc, unsigned long nr) > > +{ > > + if (cc) { > > + return test_facility(nr, cc->fac_list) ? true : false; > > + } > > + return false; > > +} > > Where do you see this being used? Good spot, it's not being used yet. It's planned to be used with a patch that implements zPCI related instructions on QEMU side. Maybe you have seen the discussion from Frank Blaschka in this e-mail list in regard to that. Michael From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Mueller Subject: Re: [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines Date: Fri, 20 Feb 2015 17:12:49 +0100 Message-ID: <20150220171249.210a0236@bee> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-11-git-send-email-mimu@linux.vnet.ibm.com> <54E75AA2.9070503@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54E75AA2.9070503@twiddle.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Archive: List-Post: To: Richard Henderson Cc: linux-s390@vger.kernel.org, frank.blaschka@de.ibm.com, kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber List-ID: On Fri, 20 Feb 2015 08:02:42 -0800 Richard Henderson wrote: > > +/** > > + * s390_test_facility - test if given facility bit is set facility list > > + * of given cpu class > > + * @class: address of cpu class to test > > + * @nr: bit number to test > > + * > > + * Returns: true in case it is set > > + * false in case it is not set > > + */ > > +bool s390_test_facility(S390CPUClass *cc, unsigned long nr) > > +{ > > + if (cc) { > > + return test_facility(nr, cc->fac_list) ? true : false; > > + } > > + return false; > > +} > > Where do you see this being used? Good spot, it's not being used yet. It's planned to be used with a patch that implements zPCI related instructions on QEMU side. Maybe you have seen the discussion from Frank Blaschka in this e-mail list in regard to that. Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqCM-0003Ji-Ku for qemu-devel@nongnu.org; Fri, 20 Feb 2015 11:13:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOqCJ-0001De-6z for qemu-devel@nongnu.org; Fri, 20 Feb 2015 11:13:02 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:41242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOqCI-0001DN-St for qemu-devel@nongnu.org; Fri, 20 Feb 2015 11:12:59 -0500 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Feb 2015 16:12:57 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1887A219005F for ; Fri, 20 Feb 2015 16:12:48 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1KGCshL11010456 for ; Fri, 20 Feb 2015 16:12:54 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1KGCqs4019572 for ; Fri, 20 Feb 2015 09:12:53 -0700 Date: Fri, 20 Feb 2015 17:12:49 +0100 From: Michael Mueller Message-ID: <20150220171249.210a0236@bee> In-Reply-To: <54E75AA2.9070503@twiddle.net> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-11-git-send-email-mimu@linux.vnet.ibm.com> <54E75AA2.9070503@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: linux-s390@vger.kernel.org, frank.blaschka@de.ibm.com, kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber On Fri, 20 Feb 2015 08:02:42 -0800 Richard Henderson wrote: > > +/** > > + * s390_test_facility - test if given facility bit is set facility list > > + * of given cpu class > > + * @class: address of cpu class to test > > + * @nr: bit number to test > > + * > > + * Returns: true in case it is set > > + * false in case it is not set > > + */ > > +bool s390_test_facility(S390CPUClass *cc, unsigned long nr) > > +{ > > + if (cc) { > > + return test_facility(nr, cc->fac_list) ? true : false; > > + } > > + return false; > > +} > > Where do you see this being used? Good spot, it's not being used yet. It's planned to be used with a patch that implements zPCI related instructions on QEMU side. Maybe you have seen the discussion from Frank Blaschka in this e-mail list in regard to that. Michael