From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbbBUFQ7 (ORCPT ); Sat, 21 Feb 2015 00:16:59 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:56711 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306AbbBUFQ6 (ORCPT ); Sat, 21 Feb 2015 00:16:58 -0500 Date: Sat, 21 Feb 2015 06:16:53 +0100 From: Ingo Molnar To: Linus Torvalds Cc: Linux Kernel Mailing List , Peter Zijlstra , Thomas Gleixner , Andrew Morton Subject: Re: [GIT PULL] locking fixes Message-ID: <20150221051653.GA9524@gmail.com> References: <20150220133756.GA30528@gmail.com> <20150221050724.GA8880@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150221050724.GA8880@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > ( I've attached the build log that I saw before sending you > the pull request. ) > > The kbuild test robot which tests for warnings didn't > report one to me either. I tested a few other configs as > well: > > x86 defconfig (PARAVIRT=n): 0 warnings > 'make kvmconfig' (PARAVIRT=y): 0 warnings > x86 bootable config (attached): 0 warnings Oh, crap, I just triggered the warnings with: x86 defconfig + 'make kvmconfig' + CONFIG_PARAVIRT_SPINLOCKS=y. My bad, mea culpa ... I just tested your patch.diff and it fixed the warnings: Tested-by: Ingo Molnar Extra sad: I _did_ build and boot test paravirt spinlocks as well, but only within a test environment that does not show warnings (in general there's too many of them, even defconfig is rarely warnings free, although it is with the very latest kernel) and my burn-in test before the pull request didn't have paravirt spinlocks turned on. But you do allmodconfig tests and look at warnings so there it probably showed up straight away? Thanks, Ingo