From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbbBVDxa (ORCPT ); Sat, 21 Feb 2015 22:53:30 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:51325 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751726AbbBVDx2 (ORCPT ); Sat, 21 Feb 2015 22:53:28 -0500 Date: Sat, 21 Feb 2015 22:54:09 -0500 From: Steven Rostedt To: Joe Perches Cc: Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value Message-ID: <20150221225409.417968db@grimm.local.home> In-Reply-To: <175dfb0fba2847cb32fb4c9bb1d3f89643993414.1424573328.git.joe@perches.com> References: <175dfb0fba2847cb32fb4c9bb1d3f89643993414.1424573328.git.joe@perches.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 21 Feb 2015 18:53:51 -0800 Joe Perches wrote: > The seq_printf return value, because it's frequently misused, > will eventually be converted to void. > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to > seq_has_overflowed() and make public") > > Miscellanea: > > o Remove unused return value from trace_lookup_stack Acked-by: Steven Rostedt -- Steve > > Signed-off-by: Joe Perches > --- > kernel/trace/trace_stack.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c > index c3e4fcf..3f34496 100644 > --- a/kernel/trace/trace_stack.c > +++ b/kernel/trace/trace_stack.c > @@ -327,11 +327,11 @@ static void t_stop(struct seq_file *m, void *p) > local_irq_enable(); > } > > -static int trace_lookup_stack(struct seq_file *m, long i) > +static void trace_lookup_stack(struct seq_file *m, long i) > { > unsigned long addr = stack_dump_trace[i]; > > - return seq_printf(m, "%pS\n", (void *)addr); > + seq_printf(m, "%pS\n", (void *)addr); > } > > static void print_disabled(struct seq_file *m)