From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbbBVElx (ORCPT ); Sat, 21 Feb 2015 23:41:53 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:36366 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbbBVElu (ORCPT ); Sat, 21 Feb 2015 23:41:50 -0500 Date: Sun, 22 Feb 2015 04:41:44 +0000 From: Al Viro To: Steven Rostedt Cc: Joe Perches , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value Message-ID: <20150222044144.GD29656@ZenIV.linux.org.uk> References: <175dfb0fba2847cb32fb4c9bb1d3f89643993414.1424573328.git.joe@perches.com> <20150221225409.417968db@grimm.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150221225409.417968db@grimm.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 21, 2015 at 10:54:09PM -0500, Steven Rostedt wrote: > On Sat, 21 Feb 2015 18:53:51 -0800 > Joe Perches wrote: > > > The seq_printf return value, because it's frequently misused, > > will eventually be converted to void. > > > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to > > seq_has_overflowed() and make public") > > > > Miscellanea: > > > > o Remove unused return value from trace_lookup_stack > > Acked-by: Steven Rostedt FWIW, this one should be Cc:stable - it's a plain and simple bugfix (so are all of those that used to return the result of seq_printf() from ->show()).