From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752493AbbBWRUk (ORCPT ); Mon, 23 Feb 2015 12:20:40 -0500 Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:50373 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752194AbbBWRUj (ORCPT ); Mon, 23 Feb 2015 12:20:39 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2689:2693:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cart99_579783795901 X-Filterd-Recvd-Size: 2039 Date: Mon, 23 Feb 2015 12:20:36 -0500 From: Steven Rostedt To: Joe Perches Cc: Al Viro , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value Message-ID: <20150223122036.4e8f34fb@gandalf.local.home> In-Reply-To: <1424601578.20944.12.camel@perches.com> References: <175dfb0fba2847cb32fb4c9bb1d3f89643993414.1424573328.git.joe@perches.com> <20150221225409.417968db@grimm.local.home> <20150222044144.GD29656@ZenIV.linux.org.uk> <1424601578.20944.12.camel@perches.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 22 Feb 2015 02:39:38 -0800 Joe Perches wrote: > > FWIW, this one should be Cc:stable - it's a plain and simple bugfix > > (so are all of those that used to return the result of seq_printf() from > > ->show()). > > Nah, it's not really a bugfix here. > > Patches sent to stable should fix actual bugs or failures. > > Sure, it's a defect, but it's only a logical one, not an > actual one. It doesn't/can't fail in practice. > > This is only a single symbol and so it can't overflow the > initial allocation. > > Besides that, the return value of the containing function > is ignored. > Right, there's nothing that will actually break with the current code. The return value is ignored in the one place it is used. And no new code is going to expect a result. It's a fix that's fine for the next merge window. It's not even important enough to get into this window. -- Steve