From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kashyap Chamarthy <kchamart@redhat.com>
Subject: Re: [nVMX] With 3.20.0-0.rc0.git5.1 on L0, booting L2 guest results
 in L1 *rebooting*
Date: Mon, 23 Feb 2015 18:09:06 +0100
Message-ID: <20150223170906.GA1055@tesla.redhat.com>
References: <20150219120719.GJ11686@tesla.redhat.com>
 <20150219150159.GA19057@potion.brq.redhat.com>
 <20150219160221.GB19057@potion.brq.redhat.com>
 <20150219211011.GE28728@tesla.redhat.com>
 <20150219222832.GA22611@tesla.redhat.com>
 <20150220161415.GA22152@potion.brq.redhat.com>
 <20150220194509.GD30563@tesla.home>
 <20150222154622.GA30296@tesla.redhat.com>
 <20150223135611.GB2102@potion.brq.redhat.com>
 <20150223161437.GI30296@tesla.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>, kvm@vger.kernel.org,
	dgilbert@redhat.com
To: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:41142 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752149AbbBWRJN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 23 Feb 2015 12:09:13 -0500
Content-Disposition: inline
In-Reply-To: <20150223161437.GI30296@tesla.redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Feb 23, 2015 at 05:14:37PM +0100, Kashyap Chamarthy wrote:
> On Mon, Feb 23, 2015 at 02:56:11PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99=
 wrote:
> > 2015-02-22 16:46+0100, Kashyap Chamarthy:
> > > Radim,
> > >=20
> > > I just tested with your patch[1] in this thread. I built a Fedora
> > > Kernel[2] with it, and installed (and booted into) it on both L0 =
and L1.=20
> > >=20
> > > Result: I don't have good news, I'm afraid: L1 *still* reboots wh=
en an
> > >         L2 guest is booted. And, L0 throws the stack trace that w=
as
> > >         previously noted on this thread:
> >=20
> > Thanks, I'm puzzled though ... isn't it possible that a wrong kerne=
l
> > sneaked into grub?
>=20
> Hmm, unlikely - I just double-confirmed that I'm running the same
> patched Kernel (3.20.0-0.rc0.git9.1.fc23.x86_64) on both L0 and L1.

[Correcting myself here.]

Unfortunately, I was double-wrong and your guess is right -- I seemed t=
o
have made _two_ Kernel builds (one doesn't contain your patch, and the
other) and now not sure _which_ one I used as I didn't add a custom tag=
=2E
To confuse more, I pointed the URL to wrong build (without your fix)
previously in this thread - so likely I must have used that in my last
test.

The correct build is here:

    http://koji.fedoraproject.org/koji/taskinfo?taskID=3D9006612

And, the build log does confirm the 'nvmx-fix.patch' that was applied

    https://kojipkgs.fedoraproject.org//work/tasks/6612/9006612/build.l=
og

The contents of the patch, I just generated a patch with `diff -u orig
new > nvmx-fix.patch` forgetting that the Fedora Kernel handles git
formatted patches just fine.

$ cat nvmx-fix.patch=20
--- vmx.c.orig  2015-02-20 19:09:49.850841320 +0100
+++ vmx.c   2015-02-20 19:11:12.153491715 +0100
@@ -2038,6 +2038,9 @@
 {
    struct vmcs12 *vmcs12 =3D get_vmcs12(vcpu);
=20
+    if (to_vmx(vcpu)->nested.nested_run_pending)
+        return 0;
+
    if (!(vmcs12->exception_bitmap & (1u << nr)))
        return 0;

So, my conclusion was wrong and need to report back with the _proper_
Kernel build.

--=20
/kashyap