From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbbBWR51 (ORCPT ); Mon, 23 Feb 2015 12:57:27 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:50730 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbbBWR50 (ORCPT ); Mon, 23 Feb 2015 12:57:26 -0500 Date: Mon, 23 Feb 2015 09:57:16 -0800 From: Guenter Roeck To: Daniel Lezcano Cc: Oleksij Rempel , linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH] clocksource: whitelist asm9260_timer driver for ARM Message-ID: <20150223175716.GA22430@roeck-us.net> References: <54D9F61E.6040206@roeck-us.net> <1423583876-32758-1-git-send-email-linux@rempel-privat.de> <54E43C96.6060008@roeck-us.net> <54EB67FF.5050908@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54EB67FF.5050908@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020201.54EB6A05.01DF,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 3 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 23, 2015 at 06:48:47PM +0100, Daniel Lezcano wrote: > On 02/18/2015 08:17 AM, Guenter Roeck wrote: > >On 02/10/2015 07:57 AM, Oleksij Rempel wrote: > >>For now it is easier to allow only tested platforms, instead of > >>fighting with different platform specific issues. > >> > >>This patch is fixing compile error on ARCH=SPARC and SPARC64: > >> > >>Building sparc64:allmodconfig ... failed > >>-------------- > >>Error log: > >>drivers/built-in.o: In function `asm9260_timer_init': > >>asm9260_timer.c:(.init.text+0x60d4): undefined reference to > >>`of_io_request_and_map' > >> > >>Tested-by: Guenter Roeck > >>Reported-by: Guenter Roeck > >>Signed-off-by: Oleksij Rempel > > > >The problem solved by this patch has affected linux-next > >for almost a month, the problem is now in mainline, yet > >I have not seen feedback from anyone about it. > > > >Did the patch get lost, or is there some problem with it ? > > Hi Guenter, Oleksij, > > so I reviewed the patch more in detail. > > The sparc/sparc64 configuration shouldn't select this timer. > > What do you think about the following patch ? > Yes, that makes sense to me. What it really means is that no architecture but MACH_ASM9260 should select the ASM9260 timer driver, and that it must always be present on MACH_ASM9260 (is that true, or should it still be configurable ?). I just hope that _some_ patch fixing the build will make it into the upstream kernel before 4.0 is released ;-). Thanks, Guenter > diff --git a/arch/arm/mach-asm9260/Kconfig b/arch/arm/mach-asm9260/Kconfig > index 8423be7..5224120 100644 > --- a/arch/arm/mach-asm9260/Kconfig > +++ b/arch/arm/mach-asm9260/Kconfig > @@ -2,5 +2,7 @@ config MACH_ASM9260 > bool "Alphascale ASM9260" > depends on ARCH_MULTI_V5 > select CPU_ARM926T > + select ASM9260_TIMER > + select GENERIC_CLOCKEVENTS > help > Support for Alphascale ASM9260 based platform. > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 72a3827..f9c1995 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -60,6 +60,11 @@ config VT8500_TIMER > config CADENCE_TTC_TIMER > bool > > +config ASM9260_TIMER > + bool > + select CLKSRC_MMIO > + select CLKSRC_OF > + > config CLKSRC_NOMADIK_MTU > bool > depends on (ARCH_NOMADIK || ARCH_U8500) > @@ -235,15 +240,4 @@ config CLKSRC_MIPS_GIC > bool > depends on MIPS_GIC > select CLKSRC_OF > - > -config ASM9260_TIMER > - bool "Alphascale ASM9260 timer driver" > - depends on GENERIC_CLOCKEVENTS > - select CLKSRC_MMIO > - select CLKSRC_OF > - default y if MACH_ASM9260 > - help > - This enables build of a clocksource and clockevent driver for > - the 32-bit System Timer hardware available on a Alphascale ASM9260. > - > endmenu > > > > > > > > >>--- > >> drivers/clocksource/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > >>index bfaaae4..39d5c11 100644 > >>--- a/drivers/clocksource/Kconfig > >>+++ b/drivers/clocksource/Kconfig > >>@@ -231,7 +231,7 @@ config CLKSRC_MIPS_GIC > >> > >> config ASM9260_TIMER > >> bool "Alphascale ASM9260 timer driver" > >>- depends on GENERIC_CLOCKEVENTS > >>+ depends on GENERIC_CLOCKEVENTS && ARM > >> select CLKSRC_MMIO > >> select CLKSRC_OF > >> default y if MACH_ASM9260 > >> > > > > > -- > Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: Facebook | > Twitter | > Blog >