From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752440AbbBXAzi (ORCPT ); Mon, 23 Feb 2015 19:55:38 -0500 Received: from pmta2.delivery1.ore.mailhop.org ([54.149.155.156]:34782 "EHLO pmta2.delivery1.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbbBXAzh (ORCPT ); Mon, 23 Feb 2015 19:55:37 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX193MJa3P2M2PERM//tkmxbA Date: Mon, 23 Feb 2015 16:41:57 -0800 From: Tony Lindgren To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, rjw@rjwysocki.net, tglx@linutronix.de Subject: Re: [PATCH 25/35] ARM: OMAP: Use explicit broadcast oneshot control function Message-ID: <20150224004157.GO32521@atomide.com> References: <20150216121435.203983131@infradead.org> <20150216122413.475894978@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150216122413.475894978@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra [150216 05:13]: > From: Thomas Gleixner > > Replace the clockevents_notify() call with an explicit function call. > > Signed-off-by: Thomas Gleixner > Cc: Tony Lindgren Works for me: Tested-by: Tony Lindgren > --- > arch/arm/mach-omap2/cpuidle44xx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > Index: linux/arch/arm/mach-omap2/cpuidle44xx.c > =================================================================== > --- linux.orig/arch/arm/mach-omap2/cpuidle44xx.c > +++ linux/arch/arm/mach-omap2/cpuidle44xx.c > @@ -84,7 +84,6 @@ static int omap_enter_idle_coupled(struc > { > struct idle_statedata *cx = state_ptr + index; > u32 mpuss_can_lose_context = 0; > - int cpu_id = smp_processor_id(); > > /* > * CPU0 has to wait and stay ON until CPU1 is OFF state. > @@ -112,7 +111,7 @@ static int omap_enter_idle_coupled(struc > mpuss_can_lose_context = (cx->mpu_state == PWRDM_POWER_RET) && > (cx->mpu_logic_state == PWRDM_POWER_OFF); > > - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &cpu_id); > + tick_broadcast_enter(); > > /* > * Call idle CPU PM enter notifier chain so that > @@ -169,7 +168,7 @@ static int omap_enter_idle_coupled(struc > if (dev->cpu == 0 && mpuss_can_lose_context) > cpu_cluster_pm_exit(); > > - clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu_id); > + tick_broadcast_exit(); > > fail: > cpuidle_coupled_parallel_barrier(dev, &abort_barrier); > >