From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754193AbbBZVN2 (ORCPT ); Thu, 26 Feb 2015 16:13:28 -0500 Received: from h2.hallyn.com ([78.46.35.8]:42514 "EHLO h2.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475AbbBZVN0 (ORCPT ); Thu, 26 Feb 2015 16:13:26 -0500 Date: Thu, 26 Feb 2015 15:13:24 -0600 From: "Serge E. Hallyn" To: Christoph Lameter Cc: "Serge E. Hallyn" , Serge Hallyn , Serge Hallyn , Andy Lutomirski , Aaron Jones , "Ted Ts'o" , linux-security-module@vger.kernel.org, akpm@linuxfoundation.org, "Andrew G. Morgan" , Mimi Zohar , Austin S Hemmelgarn , Markku Savela , Jarkko Sakkinen , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Michael Kerrisk , Jonathan Corbet Subject: Re: [PATCH] capabilities: Ambient capability set V1 Message-ID: <20150226211324.GB19273@mail.hallyn.com> References: <20150224164429.GB29685@ubuntumail> <20150225033247.GC29685@ubuntumail> <20150226153524.GC15182@mail.hallyn.com> <20150226193200.GA17709@mail.hallyn.com> <20150226203405.GB18926@mail.hallyn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 26, 2015 at 03:09:48PM -0600, Christoph Lameter wrote: > On Thu, 26 Feb 2015, Serge E. Hallyn wrote: > > > > Same problem as before. The ambient bits will not be set in pE'. > > > > And what if I weren't scatterbrained and we did > > > > if (pA) > > pE' = pP' > > else > > pE' = pP' & fE > > > > All pP' bits would be set in pE'. > > Ok and the non ambient case would break because fE is not available? > Doesnt this reduce to > > pE' = pP' > > in either case? No. fE is not "not available". If you set it with setcap, you *should* (if i'm tinking right) find fE full when calculating the new capability sets, because of magic_etc. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH] capabilities: Ambient capability set V1 Date: Thu, 26 Feb 2015 15:13:24 -0600 Message-ID: <20150226211324.GB19273@mail.hallyn.com> References: <20150224164429.GB29685@ubuntumail> <20150225033247.GC29685@ubuntumail> <20150226153524.GC15182@mail.hallyn.com> <20150226193200.GA17709@mail.hallyn.com> <20150226203405.GB18926@mail.hallyn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Lameter Cc: "Serge E. Hallyn" , Serge Hallyn , Serge Hallyn , Andy Lutomirski , Aaron Jones , Ted Ts'o , linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, "Andrew G. Morgan" , Mimi Zohar , Austin S Hemmelgarn , Markku Savela , Jarkko Sakkinen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Kerrisk , Jonathan Corbet List-Id: linux-api@vger.kernel.org On Thu, Feb 26, 2015 at 03:09:48PM -0600, Christoph Lameter wrote: > On Thu, 26 Feb 2015, Serge E. Hallyn wrote: > > > > Same problem as before. The ambient bits will not be set in pE'. > > > > And what if I weren't scatterbrained and we did > > > > if (pA) > > pE' = pP' > > else > > pE' = pP' & fE > > > > All pP' bits would be set in pE'. > > Ok and the non ambient case would break because fE is not available? > Doesnt this reduce to > > pE' = pP' > > in either case? No. fE is not "not available". If you set it with setcap, you *should* (if i'm tinking right) find fE full when calculating the new capability sets, because of magic_etc.