From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754812AbbB0PqF (ORCPT ); Fri, 27 Feb 2015 10:46:05 -0500 Received: from mail-wg0-f50.google.com ([74.125.82.50]:38548 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbbB0PqD (ORCPT ); Fri, 27 Feb 2015 10:46:03 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Rob Herring Subject: Re: [PATCH] ARM: /proc/cpuinfo: DT: Add support for Revision Date: Fri, 27 Feb 2015 16:45:58 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-46-generic; KDE/4.14.2; x86_64; ; ) Cc: Russell King , Will Deacon , Ivaylo Dimitrov , Sebastian Reichel , Pavel Machek , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Tony Lindgren References: <1403110464-29646-1-git-send-email-pali.rohar@gmail.com> <201501301514.14884@pali> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3030856.jDFVGpkUf7"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201502271645.58765@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3030856.jDFVGpkUf7 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Friday 30 January 2015 22:03:36 Rob Herring wrote: > lOn Fri, Jan 30, 2015 at 8:14 AM, Pali Roh=C3=A1r=20 wrote: > > On Monday 26 January 2015 21:22:27 Rob Herring wrote: > >> On Mon, Jan 26, 2015 at 1:09 PM, Pali Roh=C3=A1r > >=20 > > wrote: > >> > Ok, here is patch which set Revision field (global > >> > variable >=20 > >> > system_rev) in /proc/cpuinfo from DT revision property: > [...] >=20 > >> > I do not know which DT property to use for storing HW > >> > Revision, so if "/revision" is not correct one, let me > >> > know what to use instead. Also you can add my > >> > Signed-off-by for both patches. > >>=20 > >> It is the correct property, but /revision in DT is a > >> string. > >>=20 > >> You need to add your own sign-off. > >>=20 > >> Rob > >=20 > > Any documentation which says that /revision is string? >=20 > Sorry, I was confusing this with serial-number, so I guess a > number is fine here. >=20 > > If it is really string, how to store ATAG_REVISON (number) > > to string? dec or hex? >=20 > However /proc/cpuinfo displays it would be fine if you stay > with a string. >=20 > Rob I will send new patch which will store number value as string. So=20 same output will be in /proc/cpuinfo and in DT /revision. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart3030856.jDFVGpkUf7 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlTwkTYACgkQi/DJPQPkQ1KZ+gCgvlBFn24/2c0P5dSZUsNLIFYT XJQAn2j1/QactyxAQmNbTL7Mkf+ed0m1 =Vmrp -----END PGP SIGNATURE----- --nextPart3030856.jDFVGpkUf7-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: pali.rohar@gmail.com (Pali =?utf-8?q?Roh=C3=A1r?=) Date: Fri, 27 Feb 2015 16:45:58 +0100 Subject: [PATCH] ARM: /proc/cpuinfo: DT: Add support for Revision In-Reply-To: References: <1403110464-29646-1-git-send-email-pali.rohar@gmail.com> <201501301514.14884@pali> Message-ID: <201502271645.58765@pali> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 30 January 2015 22:03:36 Rob Herring wrote: > lOn Fri, Jan 30, 2015 at 8:14 AM, Pali Roh?r wrote: > > On Monday 26 January 2015 21:22:27 Rob Herring wrote: > >> On Mon, Jan 26, 2015 at 1:09 PM, Pali Roh?r > > > > wrote: > >> > Ok, here is patch which set Revision field (global > >> > variable > > >> > system_rev) in /proc/cpuinfo from DT revision property: > [...] > > >> > I do not know which DT property to use for storing HW > >> > Revision, so if "/revision" is not correct one, let me > >> > know what to use instead. Also you can add my > >> > Signed-off-by for both patches. > >> > >> It is the correct property, but /revision in DT is a > >> string. > >> > >> You need to add your own sign-off. > >> > >> Rob > > > > Any documentation which says that /revision is string? > > Sorry, I was confusing this with serial-number, so I guess a > number is fine here. > > > If it is really string, how to store ATAG_REVISON (number) > > to string? dec or hex? > > However /proc/cpuinfo displays it would be fine if you stay > with a string. > > Rob I will send new patch which will store number value as string. So same output will be in /proc/cpuinfo and in DT /revision. -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: