From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCHv2 05/15] ARM: mvebu: add stdout-path to all armada-*.dts Date: Sat, 28 Feb 2015 10:55:51 +0100 Message-ID: <20150228105551.7b6532f8@free-electrons.com> References: <1424451874-25375-1-git-send-email-thomas.petazzoni@free-electrons.com> <1424451874-25375-6-git-send-email-thomas.petazzoni@free-electrons.com> <54EB4E9B.6010001@free-electrons.com> <20150227174851.390d9f58@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from down.free-electrons.com ([37.187.137.238]:54752 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750728AbbB1Jz6 (ORCPT ); Sat, 28 Feb 2015 04:55:58 -0500 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Rob Herring Cc: Gregory CLEMENT , Andrew Lunn , Mike Turquette , Jason Cooper , Pawel Moll , "devicetree@vger.kernel.org" , Linus Walleij , Ian Campbell , Stephen Boyd , Nadav Haklai , "linux-gpio@vger.kernel.org" , Lior Amsalem , Rob Herring , Ezequiel Garcia , Kumar Gala , Mark Rutland , Tawfik Bayouk , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth Dear Rob Herring, On Fri, 27 Feb 2015 11:42:43 -0600, Rob Herring wrote: > > Unfortunately, this doesn't seem to work at all: > > This must have all been tested on QEMU (or Fast Models?) which ignores > baud rate. Ok. > > So it gets the right port name, the right idx, just the options are > > null. It shouldn't be an issue since the serial port is already > > initialized by the bootloader. > > I think the default baudrate is 9600, not what the bootloader set. That might explain the issue then. > You need the full path here though. But garbage should not crash things. Indeed, I was surprised that a different DT string was crashing the kernel. > > It is worth mentioning that this also happens with > > > > stdout-path = "uart0:115200n8"; > > > > which was explicitly suggested by Mark in his e-mail. uart0 is an alias > > to the proper DT node, since stdout-path = &uart0; works almost fine. > > Mark forgot the '&'. So does 'stdout-path = "&uart0:115200n8";' work? I don't have the board at hand right now, will try this on Tuesday when coming back to the office. Thanks for the suggestion! Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Sat, 28 Feb 2015 10:55:51 +0100 Subject: [PATCHv2 05/15] ARM: mvebu: add stdout-path to all armada-*.dts In-Reply-To: References: <1424451874-25375-1-git-send-email-thomas.petazzoni@free-electrons.com> <1424451874-25375-6-git-send-email-thomas.petazzoni@free-electrons.com> <54EB4E9B.6010001@free-electrons.com> <20150227174851.390d9f58@free-electrons.com> Message-ID: <20150228105551.7b6532f8@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Rob Herring, On Fri, 27 Feb 2015 11:42:43 -0600, Rob Herring wrote: > > Unfortunately, this doesn't seem to work at all: > > This must have all been tested on QEMU (or Fast Models?) which ignores > baud rate. Ok. > > So it gets the right port name, the right idx, just the options are > > null. It shouldn't be an issue since the serial port is already > > initialized by the bootloader. > > I think the default baudrate is 9600, not what the bootloader set. That might explain the issue then. > You need the full path here though. But garbage should not crash things. Indeed, I was surprised that a different DT string was crashing the kernel. > > It is worth mentioning that this also happens with > > > > stdout-path = "uart0:115200n8"; > > > > which was explicitly suggested by Mark in his e-mail. uart0 is an alias > > to the proper DT node, since stdout-path = &uart0; works almost fine. > > Mark forgot the '&'. So does 'stdout-path = "&uart0:115200n8";' work? I don't have the board at hand right now, will try this on Tuesday when coming back to the office. Thanks for the suggestion! Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com