All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] sunvdc: don't dereference port->disk before disk probe finishes
Date: Mon, 02 Mar 2015 05:46:12 +0000	[thread overview]
Message-ID: <20150302.004612.409094040042578991.davem@davemloft.net> (raw)
In-Reply-To: <1422381112-21571-1-git-send-email-dwight.engen@oracle.com>

From: Dwight Engen <dwight.engen@oracle.com>
Date: Tue, 27 Jan 2015 12:51:52 -0500

> If the backing file for a vdisk is not present in the service domain an
> ldc reset can occur during the initial port/disk probing. The ldc reset
> logic was dereferencing port->disk, which may not have been setup yet.
> Guard against this case.
> 
> Orabug: 20362258
> 
> Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
 ...
> @@ -938,6 +938,8 @@ err_out_free_tx_ring:
>  	vdc_free_tx_ring(port);
>  
>  err_out_free_ldc:
> +	flush_work(&port->ldc_reset_work);
> +	del_timer_sync(&port->ldc_reset_timer);
>  	vio_ldc_free(&port->vio);

This hunk has absolutely nothing to do with the bug you claim
to be fixing in your commit message, and needs to be split out
into a separate fix where you explain why these two calls are
necessary and exactly what the change is fixing.

Thanks.

  reply	other threads:[~2015-03-02  5:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 17:51 [PATCH] sunvdc: don't dereference port->disk before disk probe finishes Dwight Engen
2015-03-02  5:46 ` David Miller [this message]
2015-03-30 16:42 ` chris hyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150302.004612.409094040042578991.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.