From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755153AbbCBQoJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 11:44:09 -0500
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:50672 "EHLO
	e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755096AbbCBQoA convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 11:44:00 -0500
Date: Mon, 2 Mar 2015 17:43:52 +0100
From: Michael Mueller <mimu@linux.vnet.ibm.com>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
        Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
        linux-s390@vger.kernel.org, kvm@vger.kernel.org,
        Gleb Natapov <gleb@kernel.org>, Alexander Graf <agraf@suse.de>,
        Eduardo Habkost <ehabkost@redhat.com>, linux-kernel@vger.kernel.org,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        "Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Alistair Francis <alistair.francis@xilinx.com>,
        Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine
 type none
Message-ID: <20150302174352.3715f1e4@bee>
In-Reply-To: <54F46C41.3000201@suse.de>
References: <1425300248-40277-1-git-send-email-mimu@linux.vnet.ibm.com>
	<1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com>
	<54F46C41.3000201@suse.de>
Organization: IBM
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 15030216-0013-0000-0000-000003233692
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 02 Mar 2015 14:57:21 +0100
Andreas Färber <afaerber@suse.de> wrote:

> >  int configure_accelerator(MachineState *ms)
> >  {
> > -    const char *p;
> > +    const char *p, *name;
> >      char buf[10];
> >      int ret;
> >      bool accel_initialised = false;
> >      bool init_failed = false;
> >      AccelClass *acc = NULL;
> > +    ObjectClass *oc;
> > +    bool probe_mode = false;
> >  
> >      p = qemu_opt_get(qemu_get_machine_opts(), "accel");
> >      if (p == NULL) {
> > -        /* Use the default "accelerator", tcg */
> > -        p = "tcg";
> > +        oc = (ObjectClass *) MACHINE_GET_CLASS(current_machine);
> > +        name = object_class_get_name(oc);
> > +        probe_mode = !strcmp(name, "none" TYPE_MACHINE_SUFFIX);
> > +        if (probe_mode) {
> > +            /* Use these accelerators in probe mode, tcg should be last */
> > +            p = probe_mode_accels;
> > +        } else {
> > +            /* Use the default "accelerator", tcg */
> > +            p = "tcg";
> > +        }
> >      }  
> 
> Can't we instead use an explicit ,accel=probe or ,accel=auto?
> That would then obsolete the next patch.

How would you express the following with the accel=<pseudo-accel> approach?

-probe -machine s390-ccw,accel=kvm 

Using machine "none" as default with tcg as last accelerator initialized should not break
anything.

-M none

The return code of configure_accelerator() is ignored anyway.

Thanks,
Michael


From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YSTRu-0007IS-FS
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 11:44:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YSTRn-0000f4-Kg
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 11:44:04 -0500
Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:39681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YSTRn-0000eg-CP
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 11:43:59 -0500
Received: from /spool/local
	by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mimu@linux.vnet.ibm.com>;
	Mon, 2 Mar 2015 16:43:56 -0000
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 255811B08069
	for <qemu-devel@nongnu.org>; Mon,  2 Mar 2015 16:44:12 +0000 (GMT)
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com
	[9.149.37.251])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t22GhsIn6357474
	for <qemu-devel@nongnu.org>; Mon, 2 Mar 2015 16:43:55 GMT
Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t22GhsTF013559
	for <qemu-devel@nongnu.org>; Mon, 2 Mar 2015 09:43:54 -0700
Date: Mon, 2 Mar 2015 17:43:52 +0100
From: Michael Mueller <mimu@linux.vnet.ibm.com>
Message-ID: <20150302174352.3715f1e4@bee>
In-Reply-To: <54F46C41.3000201@suse.de>
References: <1425300248-40277-1-git-send-email-mimu@linux.vnet.ibm.com>
	<1425300248-40277-2-git-send-email-mimu@linux.vnet.ibm.com>
	<54F46C41.3000201@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine
 type none
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: linux-s390@vger.kernel.org, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Alistair Francis <alistair.francis@xilinx.com>, Richard Henderson <rth@twiddle.net>

On Mon, 02 Mar 2015 14:57:21 +0100
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> >  int configure_accelerator(MachineState *ms)
> >  {
> > -    const char *p;
> > +    const char *p, *name;
> >      char buf[10];
> >      int ret;
> >      bool accel_initialised =3D false;
> >      bool init_failed =3D false;
> >      AccelClass *acc =3D NULL;
> > +    ObjectClass *oc;
> > +    bool probe_mode =3D false;
> > =20
> >      p =3D qemu_opt_get(qemu_get_machine_opts(), "accel");
> >      if (p =3D=3D NULL) {
> > -        /* Use the default "accelerator", tcg */
> > -        p =3D "tcg";
> > +        oc =3D (ObjectClass *) MACHINE_GET_CLASS(current_machine);
> > +        name =3D object_class_get_name(oc);
> > +        probe_mode =3D !strcmp(name, "none" TYPE_MACHINE_SUFFIX);
> > +        if (probe_mode) {
> > +            /* Use these accelerators in probe mode, tcg should be las=
t */
> > +            p =3D probe_mode_accels;
> > +        } else {
> > +            /* Use the default "accelerator", tcg */
> > +            p =3D "tcg";
> > +        }
> >      } =20
>=20
> Can't we instead use an explicit ,accel=3Dprobe or ,accel=3Dauto?
> That would then obsolete the next patch.

How would you express the following with the accel=3D<pseudo-accel> approac=
h?

-probe -machine s390-ccw,accel=3Dkvm=20

Using machine "none" as default with tcg as last accelerator initialized sh=
ould not break
anything.

-M none

The return code of configure_accelerator() is ignored anyway.

Thanks,
Michael