From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dan.carpenter@oracle.com>
Date: Tue, 3 Mar 2015 15:04:34 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [RFC 3/7] staging: fbtft: add lcd controller abstraction
Message-ID: <20150303120434.GN5386@mwanda>
References: <1425293669-15754-1-git-send-email-noralf@tronnes.org>
 <1425293669-15754-4-git-send-email-noralf@tronnes.org>
 <20150302114820.GH5386@mwanda>
 <54F5A1A9.9030007@tronnes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <54F5A1A9.9030007@tronnes.org>
List-ID: <driverdev-devel.linuxdriverproject.org>
To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= <noralf@tronnes.org>
Cc: gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org

On Tue, Mar 03, 2015 at 12:57:29PM +0100, Noralf Trønnes wrote:
> >>+	ret = ctrl->rotate(ctrl, rotation);
> >>+	if (!ret)
> >>+		ctrl->rotation = rotation;
> >>+
> >>+	return ret;
> >Better to check "if (ret)" consistently (error handling vs success
> >handling).
> Like this?
> 
> 	ret = ctrl->rotate(ctrl, rotation);
> 	if (ret)
> 		return ret;
> 
> 	ctrl->rotation = rotation;
> 
> 	return 0;
> 

Yeah.  This is a tiny nit.  I feel a bit silly for commenting on it now.

regards,
dan carpenter