From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756030AbbCCNIk (ORCPT ); Tue, 3 Mar 2015 08:08:40 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:40080 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753394AbbCCNIj (ORCPT ); Tue, 3 Mar 2015 08:08:39 -0500 Date: Tue, 3 Mar 2015 16:07:55 +0300 From: Dan Carpenter To: =?iso-8859-1?Q?Cl=E1udio?= Maia Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings Message-ID: <20150303130754.GO5386@mwanda> References: <1425387279-27397-1-git-send-email-crrm@isep.ipp.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425387279-27397-1-git-send-email-crrm@isep.ipp.pt> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 03, 2015 at 12:54:38PM +0000, Cláudio Maia wrote: > The following errors were fixed: > > ERROR: code indent should use tabs where possible > WARNING: line over 80 characters > > Signed-off-by: Cláudio Maia Can you resend these but split up differently. > + write_reg(par, 0x22);/* > + 5:1 1 > + 2:0 PD - Powerdown control: chip is active > + 1:1 V - Entry mode: vertical addressing > + 0:0 H - Extended instruction set control: basic > + */ > These comments are all kinds of whacky looking. You fix them in the 2/2 patch, but we don't want to have this intermidiate whacky looking patch. Just send them when they look good like in the 2/2 patch. > @@ -130,7 +133,8 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) > gpio_set_value(par->gpio.dc, 1); > ret = par->fbtftops.write(par, par->txbuf.buf, 6*84); > if (ret < 0) > - dev_err(par->info->device, "%s: write failed and returned: %d\n", __func__, ret); > + dev_err(par->info->device, "%s: write failed and returned: %d\n", > + __func__, ret); Do these non-comment fixes in a separate patch. In other words: [patch 1/2] break up a few long lines this patch doesn't touch comments [patch 2/2] make comments look good this is 1/2 and 2/2 comment changes combined regards, dan carpenter