From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932890AbbCCWBo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Mar 2015 17:01:44 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:36210 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932555AbbCCWBm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Mar 2015 17:01:42 -0500
Date: Tue, 3 Mar 2015 14:01:41 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 2/8] zram: use idr instead of `zram_devices' array
Message-Id: <20150303140141.9adbb3dae4253130aad5d16b@linux-foundation.org>
In-Reply-To: <1425386990-6339-3-git-send-email-sergey.senozhatsky@gmail.com>
References: <1425386990-6339-1-git-send-email-sergey.senozhatsky@gmail.com>
	<1425386990-6339-3-git-send-email-sergey.senozhatsky@gmail.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue,  3 Mar 2015 21:49:44 +0900 Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:

> This patch makes some preparations for dynamic device ADD/REMOVE functionality
> via /dev/zram-control interface.
> 
> Remove `zram_devices' array and switch to id-to-pointer translation (idr).
> idr doesn't bloat zram struct with additional members, f.e. list_head, yet
> still provides ability to match the device_id with the device pointer.
> No user-space visible changes.
> 
> ...
>
> +static DEFINE_IDR(zram_index_idr);

There is no locking protecting this idr?