From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT6Jr-0002Li-Gn for qemu-devel@nongnu.org; Wed, 04 Mar 2015 05:14:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT6Jm-0001cD-G8 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 05:14:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT6Jm-0001c6-9W for qemu-devel@nongnu.org; Wed, 04 Mar 2015 05:14:18 -0500 Date: Wed, 4 Mar 2015 11:14:10 +0100 From: "Michael S. Tsirkin" Message-ID: <20150304101410.GA26213@redhat.com> References: <1425296404-12903-1-git-send-email-mst@redhat.com> <1425296404-12903-2-git-send-email-mst@redhat.com> <87ioehk39j.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ioehk39j.fsf@rustcorp.com.au> Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rusty Russell Cc: cornelia.huck@de.ibm.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > virtio 1.0 config space is in LE format for all > > devices, use modern wrappers when accessed through > > the 1.0 BAR. > > Hmm, I'm not so sure about these patches. It's easy to miss the > existence of the _modern variants, and they're 90% the same as the > legacy variants. > > But as long as it's fixed... > > Thanks, > Rusty. > PS. rng, block, net and 9p virtio 1.0 seem to work OK on BE guests (LE host). Hmm good point. What if I'll rework this to get bool legacy parameter? From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0 Date: Wed, 4 Mar 2015 11:14:10 +0100 Message-ID: <20150304101410.GA26213@redhat.com> References: <1425296404-12903-1-git-send-email-mst@redhat.com> <1425296404-12903-2-git-send-email-mst@redhat.com> <87ioehk39j.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87ioehk39j.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > virtio 1.0 config space is in LE format for all > > devices, use modern wrappers when accessed through > > the 1.0 BAR. > > Hmm, I'm not so sure about these patches. It's easy to miss the > existence of the _modern variants, and they're 90% the same as the > legacy variants. > > But as long as it's fixed... > > Thanks, > Rusty. > PS. rng, block, net and 9p virtio 1.0 seem to work OK on BE guests (LE host). Hmm good point. What if I'll rework this to get bool legacy parameter?