All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	zonque@gmail.com
Subject: Re: [PATCH] ASoC: davinci-mcasp: Allow complete shutdown of McASP when not in use
Date: Wed, 4 Mar 2015 11:30:04 +0000	[thread overview]
Message-ID: <20150304113004.GJ21293@sirena.org.uk> (raw)
In-Reply-To: <54F6DA94.2000702@ti.com>


[-- Attachment #1.1: Type: text/plain, Size: 554 bytes --]

On Wed, Mar 04, 2015 at 12:12:36PM +0200, Peter Ujfalusi wrote:
> On 03/03/2015 05:07 PM, Mark Brown wrote:

> > I see there's actually a balanced put in the resume path...  I see
> > what's going on here but I'm thinking that perhaps something more
> > explicit that calls the ops directly and checks pm_runtime_is_enabled()
> > might be clearer?

> The issue with the pm_runtime_is_enabled() is going to be in the resume path,
> as I did get_sync() it will return true at the end all the time.

You can just store the state before you do the enable...

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2015-03-04 11:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 14:26 [PATCH] ASoC: davinci-mcasp: Allow complete shutdown of McASP when not in use Peter Ujfalusi
2015-03-03 15:07 ` Mark Brown
2015-03-04 10:12   ` Peter Ujfalusi
2015-03-04 11:30     ` Mark Brown [this message]
2015-03-04 11:31       ` Peter Ujfalusi
2015-03-04 17:13         ` Mark Brown
2015-03-05 10:51           ` Peter Ujfalusi
2015-03-05 11:38             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150304113004.GJ21293@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.