From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759830AbbCDM2e (ORCPT ); Wed, 4 Mar 2015 07:28:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38012 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755288AbbCDM2d (ORCPT ); Wed, 4 Mar 2015 07:28:33 -0500 Date: Wed, 4 Mar 2015 13:27:20 +0100 From: Borislav Petkov To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andre Przywara , x86@kernel.org Subject: Re: [PATCH v3] x86: move cacheinfo sysfs to generic cacheinfo infrastructure Message-ID: <20150304122720.GD3663@pd.tnic> References: <1424715265-21407-1-git-send-email-sudeep.holla@arm.com> <1425470416-20691-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1425470416-20691-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2015 at 12:00:16PM +0000, Sudeep Holla wrote: > This patch removes the redundant sysfs cacheinfo code by reusing > the newly introduced generic cacheinfo infrastructure through the > commit 246246cbde5e ("drivers: base: support cpu cache information > interface to userspace via sysfs") > > The private pointer provided by the cacheinfo is used to implement > the AMD L3 cache specific attributes. > > Note that with v4.0-rc1, commit 513e3d2d11c9 ("cpumask: always use > nr_cpu_ids in formatting and parsing functions") in particular changes > from long format to shorter one for all cpumasks sysfs entries. As the > consequence of the same, even the shared_cpu_map in the cacheinfo sysfs > was also changed. > > This patch neither alters any existing sysfs entries nor their formating, > however since the generic cacheinfo has switched to use the device > attributes instead of the traditional raw kobjects, a directory named > "power" along with its standard attributes are added similar to any > other device. > > Signed-off-by: Sudeep Holla > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Borislav Petkov > Cc: Andre Przywara > Cc: x86@kernel.org Applied, thanks guys. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --