From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Subject: Re: [PATCH] ixgbe: do not include CRC in Tx byte count
Date: Wed, 4 Mar 2015 15:06:41 -0800
Message-ID: <20150304150641.1462cce6@urahara>
References: <1421994224-2127-1-git-send-email-stephen@networkplumber.org>
 <7916082.1WV7FdSlI3@xps13> <20150127113847.3d4d32a0@uryu.home.lan>
 <9265c0d3b03e4f33b7823139be7b3b91@BRMWP-EXMB11.corp.brocade.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>, Stephen Hemminger <shemming-yk0uUPyXz1dBDgjK7y7TUQ@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <9265c0d3b03e4f33b7823139be7b3b91-sI283RzA5cMA50eAn2D9H4CDckiq/fhJZeezCHUQhQ4@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Wed, 4 Mar 2015 20:55:05 +0000
Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:

> Anyone to carefully review this patch?
> 
> 2015-01-27 11:38, Stephen Hemminger:
> > On Tue, 27 Jan 2015 11:11:39 +0100
> > Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:
> >   
> > > Hi Stephen,
> > > 
> > > 2015-01-22 22:23, stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org:  
> > > > From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
> > > > 
> > > > The ixgbe driver was including CRC in the transmit packet byte
> > > > count, but not for packets received. This was notice when forwarding and
> > > > the number of bytes received was greater than the number of bytes transmitted  
> > > 
> > > Tx includes CRC and Rx count is greater, really?  

Yes. This is observable fact.
The gotc register includes CRC and the per-queue register do not.