All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfeldma@gmail.com
Cc: netdev@vger.kernel.org, jiri@resnulli.us, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next v3 0/7] switchdev: add IPv4 routing offload
Date: Thu, 05 Mar 2015 00:07:17 -0500 (EST)	[thread overview]
Message-ID: <20150305.000717.479876439702052068.davem@davemloft.net> (raw)
In-Reply-To: <CAE4R7bDTV38bR2Oo2nfO6gFQQBhC4avmWdYeK_2sj1bqZWQiEg@mail.gmail.com>

From: Scott Feldman <sfeldma@gmail.com>
Date: Wed, 4 Mar 2015 20:50:28 -0800

> I don't know what to do for v4.  Bummer, we got pretty close.  My only
> ideas right now involve more code to handling unwinding some routes
> from hw when related route fails to install to hw.

Scott:

1) route ADD

	driver has NULL ndo_op, do nothing, install sw route

	ndo_op SUCCESS, return 0, all is good and the caller sets the
	external bit

	ndo_op FAILURE, returns any error code, any and all external
	routes are removed with DEL ndo_op, all external bits are
	cleared

2) route DEL

	driver has NULL ndo_op, do nothing

	ndo_op SUCCESS, return 0, clear external bit

	ndo_op FAILURE, pass failure up the delete call stack

  parent reply	other threads:[~2015-03-05  5:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 23:31 [PATCH net-next v3 0/7] switchdev: add IPv4 routing offload sfeldma
2015-03-03 23:31 ` [PATCH net-next v3 1/7] rtnetlink: add RTNH_F_EXTERNAL flag for fib offload sfeldma
2015-03-03 23:31 ` [PATCH net-next v3 2/7] netdevice: add IPv4 fib add/del ops sfeldma
2015-03-03 23:31 ` [PATCH net-next v3 3/7] switchdev: add IPv4 fib ndo ops wrappers sfeldma
2015-03-03 23:31 ` [PATCH net-next v3 4/7] switchdev: don't support custom ip rules, for now sfeldma
2015-03-03 23:31 ` [PATCH net-next v3 5/7] switchdev: implement IPv4 fib ndo wrappers sfeldma
2015-03-03 23:31 ` [PATCH net-next v3 6/7] fib: hook IPv4 fib for hardware offload sfeldma
2015-03-04  0:01   ` Alexander Duyck
2015-03-04  3:16     ` Scott Feldman
2015-03-05  7:03   ` John Fastabend
2015-03-05  7:05     ` David Miller
2015-03-03 23:32 ` [PATCH net-next v3 7/7] rocker: implement IPv4 fib offloading sfeldma
2015-03-04  5:38 ` [PATCH net-next v3 0/7] switchdev: add IPv4 routing offload David Miller
2015-03-04  7:28   ` Scott Feldman
2015-03-04 21:06     ` David Miller
2015-03-05  4:50       ` Scott Feldman
2015-03-05  5:04         ` David Miller
2015-03-05  5:07         ` David Miller [this message]
2015-03-05  7:18       ` John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150305.000717.479876439702052068.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.