From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753345AbbCEASm (ORCPT ); Wed, 4 Mar 2015 19:18:42 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:38459 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098AbbCEASl (ORCPT ); Wed, 4 Mar 2015 19:18:41 -0500 Date: Thu, 5 Mar 2015 09:18:45 +0900 From: Sergey Senozhatsky To: minchan@kernel.org Cc: ddstreet@ieee.org, gunho.lee@lge.com, iamjoonsoo.kim@lge.com, jmarchan@redhat.com, juno.choi@lge.com, mel@csn.ul.ie, ngupta@vflare.org, semenzato@google.com, sergey.senozhatsky@gmail.com, sjennings@variantweb.net, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: + zram-support-compaction.patch added to -mm tree Message-ID: <20150305001845.GB14927@swordfish> References: <54f780fc.3sOWZKr7rufmI85r%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54f780fc.3sOWZKr7rufmI85r%akpm@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On (03/04/15 14:02), akpm@linux-foundation.org wrote: [..] > +++ a/drivers/block/zram/zram_drv.c > @@ -70,6 +70,27 @@ static inline struct zram *dev_to_zram(s > return (struct zram *)dev_to_disk(dev)->private_data; > } > > +static ssize_t compact_store(struct device *dev, > + struct device_attribute *attr, const char *buf, size_t len) > +{ > + unsigned long nr_migrated; > + struct zram *zram = dev_to_zram(dev); > + struct zram_meta *meta; > + > + down_read(&zram->init_lock); > + if (!init_done(zram)) { > + up_read(&zram->init_lock); > + return -EINVAL; > + } > + > + meta = zram->meta; > + nr_migrated = zs_compact(meta->mem_pool); > + atomic64_add(nr_migrated, &zram->stats.num_migrated); > + up_read(&zram->init_lock); > + > + return len; > +} > + > /* flag operations require table entry bit_spin_lock() being held */ > static int zram_test_flag(struct zram_meta *meta, u32 index, > enum zram_pageflags flag) let's stick to "helpers, attrs show/store, mm (meta, page), IO, zram control" function layout. so can we please put compact_store() after, say, 354 static ssize_t comp_algorithm_store(...) function? -ss > @@ -374,6 +395,7 @@ ZRAM_ATTR_RO(invalid_io); > ZRAM_ATTR_RO(notify_free); > ZRAM_ATTR_RO(zero_pages); > ZRAM_ATTR_RO(compr_data_size); > +ZRAM_ATTR_RO(num_migrated); > > static inline bool zram_meta_get(struct zram *zram) > { > @@ -1031,6 +1053,7 @@ static const struct block_device_operati > .owner = THIS_MODULE > }; > > +static DEVICE_ATTR_WO(compact); > static DEVICE_ATTR_RW(disksize); > static DEVICE_ATTR_RO(initstate); > static DEVICE_ATTR_WO(reset); > @@ -1049,6 +1072,8 @@ static struct attribute *zram_disk_attrs > &dev_attr_num_writes.attr, > &dev_attr_failed_reads.attr, > &dev_attr_failed_writes.attr, > + &dev_attr_num_migrated.attr, > + &dev_attr_compact.attr, > &dev_attr_invalid_io.attr, > &dev_attr_notify_free.attr, > &dev_attr_zero_pages.attr, > diff -puN drivers/block/zram/zram_drv.h~zram-support-compaction drivers/block/zram/zram_drv.h > --- a/drivers/block/zram/zram_drv.h~zram-support-compaction > +++ a/drivers/block/zram/zram_drv.h > @@ -78,6 +78,7 @@ struct zram_stats { > atomic64_t compr_data_size; /* compressed size of pages stored */ > atomic64_t num_reads; /* failed + successful */ > atomic64_t num_writes; /* --do-- */ > + atomic64_t num_migrated; /* no. of migrated object */ > atomic64_t failed_reads; /* can happen when memory is too low */ > atomic64_t failed_writes; /* can happen when memory is too low */ > atomic64_t invalid_io; /* non-page-aligned I/O requests */ > _ > > Patches currently in -mm which might be from minchan@kernel.org are > > mm-vmscan-fix-the-page-state-calculation-in-too_many_isolated.patch > mm-page_isolation-check-pfn-validity-before-access.patch > mm-support-madvisemadv_free.patch > mm-support-madvisemadv_free-fix.patch > x86-add-pmd_-for-thp.patch > x86-add-pmd_-for-thp-fix.patch > sparc-add-pmd_-for-thp.patch > sparc-add-pmd_-for-thp-fix.patch > powerpc-add-pmd_-for-thp.patch > arm-add-pmd_mkclean-for-thp.patch > arm64-add-pmd_-for-thp.patch > mm-dont-split-thp-page-when-syscall-is-called.patch > mm-dont-split-thp-page-when-syscall-is-called-fix.patch > mm-dont-split-thp-page-when-syscall-is-called-fix-2.patch > zram-cosmetic-zram_attr_ro-code-formatting-tweak.patch > zram-use-idr-instead-of-zram_devices-array.patch > zram-factor-out-device-reset-from-reset_store.patch > zram-reorganize-code-layout.patch > zram-add-dynamic-device-add-remove-functionality.patch > zram-remove-max_num_devices-limitation.patch > zram-report-every-added-and-removed-device.patch > zram-trivial-correct-flag-operations-comment.patch > zsmalloc-decouple-handle-and-object.patch > zsmalloc-factor-out-obj_.patch > zsmalloc-support-compaction.patch > zsmalloc-adjust-zs_almost_full.patch > zram-support-compaction.patch > zsmalloc-record-handle-in-page-private-for-huge-object.patch > zsmalloc-add-fullness-into-stat.patch > > -- > To unsubscribe from this list: send the line "unsubscribe mm-commits" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >