Re: [PATCH 1/2] phy: miphy365x: Convert to devm_kcalloc and fix wrong sizof

From: Lee Jones <lee.jones@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/2] phy: miphy365x: Convert to devm_kcalloc and fix wrong sizof
Date: Thu, 5 Mar 2015 07:53:19 +0000	[thread overview]
Message-ID: <20150305075319.GA29183@x1> (raw)
In-Reply-To: <1425520379.1637.7.camel@phoenix>

On Thu, 05 Mar 2015, Axel Lin wrote:

> Prefer devm_kcalloc over devm_kzalloc with multiply.
> In additional, use sizeof(phy) is incorrect, fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/phy/phy-miphy365x.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/phy/phy-miphy365x.c b/drivers/phy/phy-miphy365x.c
> index 61177a6..51b459d 100644
> --- a/drivers/phy/phy-miphy365x.c
> +++ b/drivers/phy/phy-miphy365x.c
> @@ -549,9 +549,8 @@ static int miphy365x_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	miphy_dev->nphys = of_get_child_count(np);
> -	miphy_dev->phys = devm_kzalloc(&pdev->dev,
> -				       sizeof(phy) * miphy_dev->nphys,
> -				       GFP_KERNEL);
> +	miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
> +				       sizeof(*miphy_dev->phys), GFP_KERNEL);
>  	if (!miphy_dev->phys)
>  		return -ENOMEM;
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog