From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YTWOs-0005wV-IT
	for qemu-devel@nongnu.org; Thu, 05 Mar 2015 09:05:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YTWOj-0004Lk-RD
	for qemu-devel@nongnu.org; Thu, 05 Mar 2015 09:05:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34338)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YTWOj-0004Le-KV
	for qemu-devel@nongnu.org; Thu, 05 Mar 2015 09:05:09 -0500
Date: Thu, 5 Mar 2015 15:04:25 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150305140425.GD5427@noname.redhat.com>
References: <cover.1424439295.git.berto@igalia.com>
	<2e1103fe919e6a065dbd2e305f8b9b0fdb687b4e.1424439295.git.berto@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2e1103fe919e6a065dbd2e305f8b9b0fdb687b4e.1424439295.git.berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Support streaming to an
	intermediate layer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 20.02.2015 um 14:53 hat Alberto Garcia geschrieben:
> This adds a new 'top' parameter to stream_start(), that specifies the
> block device where the data will be written. The image is changed to
> read-write mode during the streaming and back to read-only afterwards.
> 
> This also unblocks the stream operation in backing files.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>

The bs parameter is now only used for the following things:

1. As the default for top

2. For error handling: Any errors are reported for bs, even though they
   are actually for top. Is this correct behaviour? It looks
   questionable to me.

3. As the BDS that owns the job

My question is whether we can't simply call stream_start() with an
intermediate node as bs instead of introducing a new parameter. I'm not
completely sure about the consequences of 3., i.e. moving ownership of a
block job to some BDS somewhere down the chain, but otherwise it should
be possible and seems cleaner.

Kevin