From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTsEn-00062a-RL for qemu-devel@nongnu.org; Fri, 06 Mar 2015 08:24:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTsEj-0007j3-PV for qemu-devel@nongnu.org; Fri, 06 Mar 2015 08:24:21 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:36697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTsEj-0007hW-Em for qemu-devel@nongnu.org; Fri, 06 Mar 2015 08:24:17 -0500 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Mar 2015 12:13:52 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id E43C92190046 for ; Fri, 6 Mar 2015 12:13:41 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t26CDoFw5636380 for ; Fri, 6 Mar 2015 12:13:50 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t26CDnsl003878 for ; Fri, 6 Mar 2015 05:13:50 -0700 Date: Fri, 6 Mar 2015 13:13:47 +0100 From: Cornelia Huck Message-ID: <20150306131347.656ed8c4.cornelia.huck@de.ibm.com> In-Reply-To: <1425534531-6305-5-git-send-email-jasowang@redhat.com> References: <1425534531-6305-1-git-send-email-jasowang@redhat.com> <1425534531-6305-5-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 04/14] virtio-ccw: introduce ccw specific queue limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: Christian Borntraeger , Richard Henderson , qemu-devel@nongnu.org, Alexander Graf On Thu, 5 Mar 2015 13:48:41 +0800 Jason Wang wrote: > Instead of depending on marco, using a bus specific limit. > > Cc: Alexander Graf > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Richard Henderson > Signed-off-by: Jason Wang > --- > hw/s390x/s390-virtio-ccw.c | 7 +++++-- > hw/s390x/virtio-ccw.c | 13 +++++++------ > include/hw/s390x/s390_flic.h | 2 +- > include/hw/virtio/virtio.h | 1 + > 4 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 4874622..98a1a90 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -1026,7 +1027,7 @@ static void virtio_ccw_notify(DeviceState *d, uint16_t vector) Unfortunately just snipped off in this diff, but the code says if (vector >= 128) { > return; > } This is originating from (64 bits for queues + 64 bits for secondary indicators) - only the first bit of secondary indicators is currently used (for configuration changes). I'd suggest to change that to queue_max + 64 and add a comment /* queue indicators + secondary indicators */ or so. > > - if (vector < VIRTIO_PCI_QUEUE_MAX) { > + if (vector < virtio_get_queue_max(virtio_bus_get_device(&dev->bus))) { > if (!dev->indicators) { > return; > }