From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbbCFQXA (ORCPT ); Fri, 6 Mar 2015 11:23:00 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:48989 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbbCFQW6 (ORCPT ); Fri, 6 Mar 2015 11:22:58 -0500 Date: Fri, 6 Mar 2015 08:22:49 -0800 From: Guenter Roeck To: Greg Kroah-Hartman Cc: James Hogan , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, satoru.takeuchi@gmail.com, shuah.kh@samsung.com, stable@vger.kernel.org, linux-mips@linux-mips.org, Paolo Bonzini , Ralf Baechle , Paul Burton , Gleb Natapov , kvm@vger.kernel.org Subject: Re: [PATCH stable 3.10, 3.12, 3.14] MIPS: Export FP functions used by lose_fpu(1) for KVM Message-ID: <20150306162249.GA28962@roeck-us.net> References: <54F7BE2E.8070708@roeck-us.net> <1425571724-9480-1-git-send-email-james.hogan@imgtec.com> <20150306063034.GA6914@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150306063034.GA6914@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020204.54F9D462.0176,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 3 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 10:30:34PM -0800, Greg Kroah-Hartman wrote: > On Thu, Mar 05, 2015 at 04:08:44PM +0000, James Hogan wrote: > > [ Upstream commit 3ce465e04bfd8de9956d515d6e9587faac3375dc ] > > > > Export the _save_fp asm function used by the lose_fpu(1) macro to GPL > > modules so that KVM can make use of it when it is built as a module. > > > > This fixes the following build error when CONFIG_KVM=m due to commit > > f798217dfd03 ("KVM: MIPS: Don't leak FPU/DSP to guest"): > > > > ERROR: "_save_fp" [arch/mips/kvm/kvm.ko] undefined! > > > > Signed-off-by: James Hogan > > Fixes: f798217dfd03 (KVM: MIPS: Don't leak FPU/DSP to guest) > > Cc: Paolo Bonzini > > Cc: Ralf Baechle > > Cc: Paul Burton > > Cc: Gleb Natapov > > Cc: kvm@vger.kernel.org > > Cc: linux-mips@linux-mips.org > > Cc: # 3.10...3.15 > > Patchwork: https://patchwork.linux-mips.org/patch/9260/ > > Signed-off-by: Ralf Baechle > > [james.hogan@imgtec.com: Only export when CPU_R4K_FPU=y prior to v3.16, > > so as not to break the Octeon build which excludes FPU support. KVM > > depends on MIPS32r2 anyway.] > > Signed-off-by: James Hogan > > --- > > Appologies for the previous cavium_octeon_defconfig link breakage. > > Octeon has the symbol since 3.16, but not before. This backport should > > do the trick for stable 3.10, 3.12, and 3.14. Build tested with > > cavium_octeon_defconfig and malta_kvm_defconfig on those stable > > branches. > > --- > > arch/mips/kernel/mips_ksyms.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > Now fixed up, thanks. > My auto-builders still fail to build cavium_octeon_defconfig for 3.10 and 3.14, and as far as I can see they picked up no changes. Did you push the changes into the stable queue repository ? Thanks, Guenter