From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757072AbbCGJ3j (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Mar 2015 04:29:39 -0500
Received: from mail-wg0-f42.google.com ([74.125.82.42]:46308 "EHLO
	mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753612AbbCGJ3e (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Mar 2015 04:29:34 -0500
Date: Sat, 7 Mar 2015 10:29:29 +0100
From: Ingo Molnar <mingo@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Dave Jones <davej@codemonkey.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Richard Cochran <richardcochran@gmail.com>,
        Prarit Bhargava <prarit@redhat.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 05/12] time: Add debugging checks to warn if we see delays
Message-ID: <20150307092929.GD30888@gmail.com>
References: <1425696603-16878-1-git-send-email-john.stultz@linaro.org>
 <1425696603-16878-6-git-send-email-john.stultz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1425696603-16878-6-git-send-email-john.stultz@linaro.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* John Stultz <john.stultz@linaro.org> wrote:

> Recently there's been some request for better sanity
> checking in the time code, so that its more clear
> when something is going wrong since timekeeping issues
> could manifest in a large number of strange ways with
> various subsystems.
> 
> Thus, this patch adds some extra infrastructure to
> add a check update_wall_time to print warnings if we
> see the call delayed beyond the max_cycles overflow
> point, or beyond the clocksource max_idle_ns value
> which is currently 50% of the overflow point.

Just a changelog style nit, but isn't this easier to read:

  Thus, this patch adds some extra infrastructure to
  add a check to update_wall_time() to print warnings if we
  see the call delayed beyond the 'max_cycles' overflow
  point, or beyond the clocksource 'max_idle_ns' value
  which is currently 50% of the overflow point.

?

To mark functions with parentheses and arguments in quotes, to make 
them mix better with free form English sentences?

> +#ifdef CONFIG_DEBUG_TIMEKEEPING
> +static void timekeeping_check_update(struct timekeeper *tk, cycle_t offset)
> +{
> +
> +	cycle_t max_cycles = tk->tkr.clock->max_cycles;
> +	const char *name = tk->tkr.clock->name;
> +
> +	if (offset > max_cycles)
> +		printk_deferred("ERROR: cycle offset (%lld) is larger then"
> +			" allowed %s max_cycles (%lld)\n",
> +			offset, name, max_cycles);
> +	else if (offset > (max_cycles >> 1))
> +		printk_deferred("WARNING: cycle offset (%lld) is past"
> +			" the %s 50%% safety margin (%lld)\n",
> +			offset, name, max_cycles>>1);

s/larger then/larger than

Also, please don't break user visible messages on col80 boundaries 
just to pacify checkpatch: ignore checkpatch in these cases.

Also, plase use curly braces on multi-line statements, plus I'd shape 
it like this:

	if () {
	} else {
		if () {
		}
	}

That way the second 'if' condition in the else branch does not get 
lost in the noise of silly line breaks. (At least during email review: 
in an actual editor syntax highlighting helps.)

> +config DEBUG_TIMEKEEPING
> +	bool "Enable extra timekeeping sanity checking"
> +	help
> +	  This option will enable additional timekeeping sanity checks
> +	  which may be helpful when diagnoising issues where timekeeping

Typo.

There's really a disproportionate ratio of typos, considering how many 
iterations this patch-set has been through :-/

Or maybe I'm oversensitive to small details.

Thanks,

	Ingo