All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Dave Jones <davej@codemonkey.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Richard Cochran <richardcochran@gmail.com>,
	Prarit Bhargava <prarit@redhat.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"David S. Miller" <davem@davemloft.net>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH 10/12] clocksource: Mostly kill clocksource_register()
Date: Sat, 7 Mar 2015 10:45:12 +0100	[thread overview]
Message-ID: <20150307094511.GH30888@gmail.com> (raw)
In-Reply-To: <1425696603-16878-11-git-send-email-john.stultz@linaro.org>


* John Stultz <john.stultz@linaro.org> wrote:

> A long running project has been to cleanup remaining uses
> of clocksource_register(), replacing it with the simpler
> clocksource_register_khz/hz().

s/.$/ functions.

> However, there are a few cases where we need to self-define
> our mult/shift values, so switch the function to a more
> obviously internal __clocksource_register(), and consolidate

s/(),/() name,

> much of the internal logic so we don't have duplication.

> +	if (freq) {
> +		/*
> +		 * Calc the maximum number of seconds which we can run before
> +		 * wrapping around. For clocksources which have a mask > 32bit
> +		 * we need to limit the max sleep time to have a good
> +		 * conversion precision. 10 minutes is still a reasonable
> +		 * amount. That results in a shift value of 24 for a
> +		 * clocksource with mask >= 40bit and f >= 4GHz. That maps to
> +		 * ~ 0.06ppm granularity for NTP.

s/32bit/32-bit
s/40bit/40-bit

Thanks,

	Ingo

  reply	other threads:[~2015-03-07  9:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07  2:49 [PATCH 00/12] Increased clocksource validation and cleanups (v3) John Stultz
2015-03-07  2:49 ` [PATCH 01/12] clocksource: Simplify clocks_calc_max_nsecs logic John Stultz
2015-03-07  9:20   ` Ingo Molnar
2015-03-07  2:49 ` [PATCH 02/12] clocksource: Simplify logic around clocksource wrapping saftey margins John Stultz
2015-03-07  9:22   ` Ingo Molnar
2015-03-07  2:49 ` [PATCH 03/12] clocksource: Remove clocksource_max_deferment() John Stultz
2015-03-07  9:18   ` Ingo Molnar
2015-03-07  2:49 ` [PATCH 04/12] clocksource: Add max_cycles to clocksource structure John Stultz
2015-03-07  9:54   ` Ingo Molnar
2015-03-07  2:49 ` [PATCH 05/12] time: Add debugging checks to warn if we see delays John Stultz
2015-03-07  9:22   ` Paul Bolle
2015-03-07  9:29   ` Ingo Molnar
2015-03-07  2:49 ` [PATCH 06/12] time: Add infrastructure to cap clocksource reads to the max_cycles value John Stultz
2015-03-07  9:32   ` Ingo Molnar
2015-03-07  2:49 ` [PATCH 07/12] time: Try to catch clocksource delta underflows John Stultz
2015-03-07  9:34   ` Ingo Molnar
2015-03-07  2:49 ` [PATCH 08/12] time: Add warnings when overflows or underflows are observed John Stultz
2015-03-07  9:40   ` Ingo Molnar
2015-03-09 16:50     ` John Stultz
2015-03-10  5:05       ` Ingo Molnar
2015-03-07  2:50 ` [PATCH 09/12] clocksource: Improve clocksource watchdog reporting John Stultz
2015-03-07  2:50 ` [PATCH 10/12] clocksource: Mostly kill clocksource_register() John Stultz
2015-03-07  9:45   ` Ingo Molnar [this message]
2015-03-07  2:50 ` [PATCH 11/12] sparc: Convert to using clocksource_register_hz() John Stultz
2015-03-07  9:46   ` Ingo Molnar
2015-03-07  2:50 ` [PATCH 12/12] clocksource: Add some debug info about clocksources being registered John Stultz
2015-03-07  9:50   ` Ingo Molnar
2015-03-12  3:16     ` John Stultz
  -- strict thread matches above, loose matches on Subject: below --
2015-01-23  0:09 [PATCH 00/12][RFC] Increased clocksource validation and cleanups (v2) John Stultz
2015-01-23  0:09 ` [PATCH 10/12] clocksource: Mostly kill clocksource_register() John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150307094511.GH30888@gmail.com \
    --to=mingo@kernel.org \
    --cc=davej@codemonkey.org.uk \
    --cc=davem@davemloft.net \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=prarit@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=sboyd@codeaurora.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.