From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: virtio fixes pull for 4.0? Date: Sat, 7 Mar 2015 20:30:49 +0100 Message-ID: <20150307193049.GA32459@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, pawel.moll@arm.com, cornelia.huck@de.ibm.com To: Rusty Russell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54003 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751911AbbCGTbG (ORCPT ); Sat, 7 Mar 2015 14:31:06 -0500 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Hi Rusty! There are a bunch of (mostly virtio 1.0 related) fixes for virtio that need to go into 4.0 I think. virtio_blk: typo fix virtio_blk: fix comment for virtio 1.0 virtio_console: init work unconditionally virtio_console: avoid config access from irq virtio_balloon: set DRIVER_OK before using device seem ready? virtio_mmio: generation support virtio_mmio: fix endian-ness for mmio these two are waiting for ack by Pawel These two fix bugs in virtio 1.0 code for mmio. Host code for that was AFAIK not posted, so I can't test properly. Pawel? virtio-balloon: do not call blocking ops when !TASK_RUNNING Rusty, it seems you prefer a different fix for this issue, while Cornelia prefers mine. Maybe both me and Cornelia misunderstand the issue? I know you dealt with a ton of similar issues recently so you are more likely to be right, but I'd like to understand what's going on better all the same. Could you help please? virtio_rpmsg: set DRIVER_OK before using device Just posted this, but seems pretty obvious. I think it's a good idea to merge these patches (maybe except the !TASK_RUNNING thing) sooner rather than later, to make sure people have the time to test the fixes properly. Would you like me to pack up (some of them) them up and do a pull request? Thanks, -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUKRF-0004OR-Rn for qemu-devel@nongnu.org; Sat, 07 Mar 2015 14:31:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUKRC-0003oB-7k for qemu-devel@nongnu.org; Sat, 07 Mar 2015 14:31:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUKRB-0003o3-WD for qemu-devel@nongnu.org; Sat, 07 Mar 2015 14:31:02 -0500 Date: Sat, 7 Mar 2015 20:30:49 +0100 From: "Michael S. Tsirkin" Message-ID: <20150307193049.GA32459@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] virtio fixes pull for 4.0? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rusty Russell Cc: cornelia.huck@de.ibm.com, pawel.moll@arm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Hi Rusty! There are a bunch of (mostly virtio 1.0 related) fixes for virtio that need to go into 4.0 I think. virtio_blk: typo fix virtio_blk: fix comment for virtio 1.0 virtio_console: init work unconditionally virtio_console: avoid config access from irq virtio_balloon: set DRIVER_OK before using device seem ready? virtio_mmio: generation support virtio_mmio: fix endian-ness for mmio these two are waiting for ack by Pawel These two fix bugs in virtio 1.0 code for mmio. Host code for that was AFAIK not posted, so I can't test properly. Pawel? virtio-balloon: do not call blocking ops when !TASK_RUNNING Rusty, it seems you prefer a different fix for this issue, while Cornelia prefers mine. Maybe both me and Cornelia misunderstand the issue? I know you dealt with a ton of similar issues recently so you are more likely to be right, but I'd like to understand what's going on better all the same. Could you help please? virtio_rpmsg: set DRIVER_OK before using device Just posted this, but seems pretty obvious. I think it's a good idea to merge these patches (maybe except the !TASK_RUNNING thing) sooner rather than later, to make sure people have the time to test the fixes properly. Would you like me to pack up (some of them) them up and do a pull request? Thanks, -- MST